Add long error explanation for E0576 #65390

GuillaumeGomez · 2019-10-13T20:07:57Z

Part of #61137.

rust-highfive · 2019-10-13T20:08:00Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

rust-highfive · 2019-10-13T20:08:01Z

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

GuillaumeGomez · 2019-10-15T11:26:31Z

r? @kinnison

matthewjasper

r=me with comment addressed

matthewjasper · 2019-10-15T18:55:21Z

src/librustc_resolve/error_codes.rs

Suggested change

`Hello` trait. To fix this error, just use an existing associated type:

`Hello` trait. To fix this error, use an existing associated type:

r=me if this suggestion is adopted.

GuillaumeGomez · 2019-10-15T21:00:06Z

Since CI passed the first time, I guess I can just r+ it...

@bors: r=matthewjasper,kinnison

bors · 2019-10-15T21:00:07Z

📌 Commit fe43332caa88780b3a3183b3e08e912d9684bfb3 has been approved by matthewjasper,kinnison

@ghost

Rollup of 14 pull requests Successful merges: - #64603 (Reducing spurious unused lifetime warnings.) - #64623 (Remove last uses of gensyms) - #65235 (don't assume we can *always* find a return type hint in async fn) - #65242 (Fix suggestion to constrain trait for method to be found) - #65265 (Cleanup librustc mir err codes) - #65293 (Optimize `try_expand_impl_trait_type`) - #65307 (Try fix incorrect "explicit lifetime name needed") - #65308 (Add long error explanation for E0574) - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members) - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.) - #65402 (Add troubleshooting section to PGO chapter in rustc book.) - #65425 (Optimize `BitIter`) - #65438 (Organize `never_type` tests) - #65444 (Implement AsRef<[T]> for List<T>) Failed merges: - #65390 (Add long error explanation for E0576) r? @ghost

bors · 2019-10-16T02:53:59Z

☔ The latest upstream changes (presumably #65454) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2019-10-16T09:10:47Z

And here we go again...

@bors: r=matthewjasper,kinnison

bors · 2019-10-16T09:10:48Z

📌 Commit 562244d9a8e600d639abeb77b65df960a2e75b91 has been approved by matthewjasper,kinnison

@ghost

Rollup of 19 pull requests Successful merges: - #65016 (Always inline `mem::{size_of,align_of}` in debug builds) - #65197 (Prepare `MutVisitor`s to handle interned projections) - #65201 (Disable Go and OCaml bindings when building LLVM) - #65334 (Add long error explanation for E0575) - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic) - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions) - #65472 (Use a sharded dep node to dep node index map) - #65480 (Speed up `LexicalResolve::expansion()`) - #65493 (Add long error explanation for E0584) - #65496 (properly document panics in div_euclid and rem_euclid) - #65498 (Plugins deprecation: don’t suggest simply removing the attribute) - #65508 (add option to ping llvm ice-breakers to triagebot) - #65511 (save-analysis: Nest tables when processing impl block definitions) - #65513 (reorder fmt docs for more clarity) - #65532 (doc: make BitSet intro more short) - #65535 (rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct.) - #65540 (show up some extra info when t!() fails) - #65549 (Fix left/right shift typo in wrapping rotate docs) - #65552 (Clarify diagnostics when using `~` as a unary op) Failed merges: - #65390 (Add long error explanation for E0576) - #65434 (Add long error explanation for E0577) - #65471 (Add long error explanation for E0578) r? @ghost

bors · 2019-10-19T04:54:25Z

☔ The latest upstream changes (presumably #65570) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2019-10-21T03:33:25Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout long-err-explanation-E0576 (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self long-err-explanation-E0576 --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging src/test/ui/ufcs/ufcs-partially-resolved.stderr
CONFLICT (content): Merge conflict in src/test/ui/ufcs/ufcs-partially-resolved.stderr
Auto-merging src/librustc_resolve/error_codes.rs
CONFLICT (content): Merge conflict in src/librustc_resolve/error_codes.rs
Automatic merge failed; fix conflicts and then commit the result.

GuillaumeGomez · 2019-10-23T12:49:10Z

Rebased.

matthewjasper · 2019-10-24T19:30:34Z

@bors r=matthewjasper,kinnison

bors · 2019-10-24T19:30:36Z

📌 Commit 530d709 has been approved by matthewjasper,kinnison

bors · 2019-10-24T19:30:37Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

…-E0576, r=matthewjasper,kinnison Add long error explanation for E0576 Part of rust-lang#61137.

@ghost

Rollup of 9 pull requests Successful merges: - #62959 (Add by-value iterator for arrays ) - #65390 (Add long error explanation for E0576) - #65408 (reorder config.toml.example options and add one missing option) - #65414 (ignore uninhabited non-exhaustive variant fields) - #65666 (Deprecated proc_macro doesn't trigger warning on build library) - #65742 (Pre-expansion gate most of the things) - #65747 (Adjust the tracking issue for `untagged_unions`.) - #65763 (Changed APIT with explicit generic args span to specific arg spans) - #65775 (Fix more `ReEmpty` ICEs) Failed merges: - #65519 (trait-based structural match implementation) r? @ghost

bors · 2019-10-25T07:47:19Z

☔ The latest upstream changes (presumably #65793) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive assigned matthewjasper Oct 13, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2019

GuillaumeGomez mentioned this pull request Oct 13, 2019

Add missing long error code explanations #61137

Closed

100 tasks

matthewjasper reviewed Oct 15, 2019

View reviewed changes

GuillaumeGomez force-pushed the long-err-explanation-E0576 branch from ae59dd4 to fe43332 Compare October 15, 2019 20:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2019

tmandry mentioned this pull request Oct 15, 2019

Rollup of 14 pull requests #65454

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 16, 2019

GuillaumeGomez force-pushed the long-err-explanation-E0576 branch from fe43332 to 562244d Compare October 16, 2019 09:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2019

This was referenced Oct 16, 2019

Rollup of 8 pull requests #65482

Closed

Rollup of 7 pull requests #65530

Closed

tmandry mentioned this pull request Oct 18, 2019

Rollup of 13 pull requests #65548

Closed

tmandry mentioned this pull request Oct 18, 2019

Rollup of 12 pull requests #65550

Closed

tmandry mentioned this pull request Oct 18, 2019

Rollup of 19 pull requests #65570

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2019

GuillaumeGomez added 2 commits October 23, 2019 13:07

Add long error explanation for E0576

aa733da

Update ui tests

530d709

GuillaumeGomez force-pushed the long-err-explanation-E0576 branch from 562244d to 530d709 Compare October 23, 2019 12:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2019

Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019

Rollup merge of rust-lang#65390 - GuillaumeGomez:long-err-explanation…

e25720f

…-E0576, r=matthewjasper,kinnison Add long error explanation for E0576 Part of rust-lang#61137.

Centril mentioned this pull request Oct 25, 2019

Rollup of 9 pull requests #65793

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2019

bors merged commit 530d709 into rust-lang:master Oct 25, 2019

GuillaumeGomez deleted the long-err-explanation-E0576 branch October 25, 2019 10:45

	`Hello` trait. To fix this error, just use an existing associated type:
	`Hello` trait. To fix this error, use an existing associated type:

Add long error explanation for E0576 #65390

Add long error explanation for E0576 #65390

Uh oh!

Conversation

GuillaumeGomez commented Oct 13, 2019

Uh oh!

rust-highfive commented Oct 13, 2019

Uh oh!

rust-highfive commented Oct 13, 2019

Uh oh!

GuillaumeGomez commented Oct 15, 2019

Uh oh!

matthewjasper left a comment

Choose a reason for hiding this comment

Uh oh!

matthewjasper Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

kinnison Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Oct 15, 2019

Uh oh!

bors commented Oct 15, 2019

Uh oh!

bors commented Oct 16, 2019

Uh oh!

GuillaumeGomez commented Oct 16, 2019

Uh oh!

bors commented Oct 16, 2019

Uh oh!

bors commented Oct 19, 2019

Uh oh!

bors commented Oct 21, 2019

Uh oh!

GuillaumeGomez commented Oct 23, 2019

Uh oh!

matthewjasper commented Oct 24, 2019

Uh oh!

bors commented Oct 24, 2019

Uh oh!

bors commented Oct 24, 2019

Uh oh!

bors commented Oct 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants