Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #65076

Merged
merged 31 commits into from
Oct 4, 2019
Merged

Rollup of 11 pull requests #65076

merged 31 commits into from
Oct 4, 2019

Commits on Jun 15, 2019

  1. Stabilize todo macro

    Stjepan Glavina committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    8e3b9d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. Update src/libcore/macros.rs

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    Stjepan Glavina and Centril authored Sep 4, 2019
    Configuration menu
    Copy the full SHA
    560bf1b View commit details
    Browse the repository at this point in the history
  2. Update macros.rs

    Stjepan Glavina authored Sep 4, 2019
    Configuration menu
    Copy the full SHA
    711f673 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Configuration menu
    Copy the full SHA
    445e735 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    366fdeb View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Replace mentions of IRC with Discord

    BO41 committed Oct 2, 2019
    1 Configuration menu
    Copy the full SHA
    2ab7a67 View commit details
    Browse the repository at this point in the history
  2. Set RUST_BACKTRACE=0 in tests that include a backtrace in stderr

    This removes the implicit dependency on the environment variables set
    when running `./x.py test`
    Aaron1011 committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    a336536 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2019

  1. Configuration menu
    Copy the full SHA
    a8d70d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    287ceed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b8ec97 View commit details
    Browse the repository at this point in the history
  4. --bless ui-fulldeps tests

    Centril committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    d1f95ef View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1310dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4396a1c View commit details
    Browse the repository at this point in the history
  7. The crux of the bug fix.

    Update: review feedback
    Update: placate tidy
    pnkfelix committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    3a4921c View commit details
    Browse the repository at this point in the history
  8. Allocate a new diagnostic for defaulted type parameters cannot use `S…

    …elf`
    
    (Without this commit, you still get an error (a very similar one, at
    that), but it complains about use of forward declaration, which is
    confusing since people do not necessarily think of `Self` as being
    declared at all.)
    
    Update: incorporate review feedback.
    pnkfelix committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    a18d424 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e86af1b View commit details
    Browse the repository at this point in the history
  10. update ui tests

    GuillaumeGomez committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    1d49f9a View commit details
    Browse the repository at this point in the history
  11. typo: fix typo in E0392

    mathstuf committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    126bf3b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b9ed642 View commit details
    Browse the repository at this point in the history
  13. Regression tests.

    Update: incorporate review feedback.
    pnkfelix committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    e443e1b View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#61879 - stjepang:stabilize-todo, r=withoutb…

    …oats
    
    Stabilize todo macro
    
    The `todo!` macro is just another name for `unimplemented!`.
    
    Tracking issue: rust-lang#59277
    
    This PR needs a FCP to merge.
    
    r? @withoutboats
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    f7ee31e View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#64675 - Centril:deprecate-plugin, r=oli-obk

    Deprecate `#![plugin]` & `#[plugin_registrar]`
    
    This PR deprecates `#![plugin]` and `#[plugin_registrar]`.
    
    ~A removal deadline is set: 1.44.0. This will be in 9 months from now and should give everyone who is still relying on the feature ample time to rid themselves of this dependency.~
    
    cc rust-lang#29597
    
    r? @Mark-Simulacrum
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    da0afc1 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#64690 - petrochenkov:mixed, r=dtolnay

    proc_macro API: Expose `macro_rules` hygiene
    
    Proc macros do not have direct access to our oldest and most stable hygiene kind - `macro_rules` hygiene.
    
    To emulate it macro authors have to go through two steps - first generate a temporary `macro_rules` item (using a derive, at least until rust-lang#64035 is merged), then generate a macro call to that item. Popular crates like [proc_macro_hack](https://crates.io/crates/proc-macro-hack) use this trick to generate hygienic identifiers from proc macros.
    
    I'd say that these workarounds with nested macro definitions have more chances to hit some corner cases in our hygiene system, in which we don't have full confidence.
    So, let's provide a direct access to `macro_rules` hygiene instead.
    
    This PR does that by adding a new method `Span::mixed_site` (bikeshedding is welcome) in addition to existing `Span::call_site` (stable) and `Span::def_site` (unstable).
    Identifiers with this span resolve at def-site in for local variables, labels and `$crate`, and resolve at call-site for everything else, i.e. exactly like identifiers produced by `macro_rules`.
    
    This API addition opens the way to stabilizing proc macros in expression positions (rust-lang#54727), for which use of call-site hygiene or workarounds with temporary items would be quite unfortunate.
    (`macro_rules` expanded in expression position, on the other hand, are stable since 1.0 and widely used.)
    
    r? @dtolnay @alexcrichton
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    2a9bd75 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#64706 - nikomatsakis:issue-60218-test-case,…

    … r=centril
    
    add regression test for rust-lang#60218
    
    Fixes rust-lang#60218
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    c6999a5 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#64741 - GuillaumeGomez:prevent-rustdoc-feat…

    …ure-doctests, r=QuietMisdreavus
    
    Prevent rustdoc feature doctests
    
    Part of rust-lang#61351
    
    cc @ollie27
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    69837b1 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#64842 - pnkfelix:fix-issue-61631-self-in-ty…

    …pe-param-default, r=alexreg
    
    Disallow Self in type param defaults of ADTs
    
    Fix rust-lang#61631
    
    (also includes a drive-by fix to a typo in some related diagnostic output.)
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    27c9052 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#65004 - BO41:mentions, r=alexcrichton

    Replace mentions of IRC with Discord
    
    Revival of rust-lang#61531
    
    closes rust-lang#61524
    
    what was the outcome of this? rust-lang#61531 (comment)
    
    should this be changed in this PR as well? rust-lang#61531 (comment)
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    4886f35 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#65018 - Aaron1011:fix/backtrace-stderr, r=n…

    …ikomatsakis
    
    Set RUST_BACKTRACE=0 in tests that include a backtrace in stderr
    
    This removes the implicit dependency on the environment variables set
    when running `./x.py test`
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    211bc4a View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#65055 - GuillaumeGomez:long-err-explanation…

    …-E0556, r=petrochenkov
    
    Add long error explanation for E0556
    
    Part of rust-lang#61137
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    dd9ccb2 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#65056 - spastorino:place-mut-visitor-adjust…

    …s, r=oli-obk
    
    Make visit projection iterative
    
    r? @oli-obk
    
    /cc @nikomatsakis
    tmandry authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    4a25c3c View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    cc5dcfa View commit details
    Browse the repository at this point in the history