Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully integrate derive helpers into name resolution #64694

Merged
merged 4 commits into from
Nov 16, 2019
Merged

Fully integrate derive helpers into name resolution #64694

merged 4 commits into from
Nov 16, 2019

Commits on Nov 16, 2019

  1. resolve: Scope::DeriveHelpers -> Scope::DeriveHelpersCompat 

    These helpers are resolved before their respective derives through a kind of look ahead into future expansions.
Some of these will migrate to proper resolution, others will be deprecated.

```
#[trait_helper] // Deprecate
#[derive(Trait)]
#[trait_helper] // Migrate to proper resolution
```
    @petrochenkov
    petrochenkov committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    c064630 View commit details
    Browse the repository at this point in the history

  2. resolve: Introduce a new scope for derive helpers

    @petrochenkov
    petrochenkov committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    a3126a5 View commit details
    Browse the repository at this point in the history

  3. expand: Stop marking derive helper attributes as known 

    Pass them through name resolution instead
    @petrochenkov
    petrochenkov committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    8085228 View commit details
    Browse the repository at this point in the history

  4. Add some more tests

    @petrochenkov
    petrochenkov committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    8668c1a View commit details
    Browse the repository at this point in the history