Stabilize `#[non_exhaustive]` (RFC 2008) #64639

davidtwco · 2019-09-20T20:44:33Z

This pull request stabilizes the #[non_exhaustive] attribute, which is used to indicate that a type will have more fields / variants added in the future. It can be applied to structs, enums and enum variants. See #44109 (comment) for the stabilization report.

r? @Centril

Centril

Thanks! Once FCP completes, r=me with these nits addressed.

src/libsyntax/feature_gate/accepted.rs

src/libsyntax/feature_gate/builtin_attrs.rs

davidtwco · 2019-10-06T09:05:43Z

Updated this PR after #65130 landed.

Centril · 2019-10-06T20:37:52Z

Seems like a bug was found meanwhile in #65157 which is fallout from #60529. Ideally this should be fixed before we stabilize the feature. cc @Nadrieril.

Centril · 2019-10-25T08:06:36Z

#65414 just landed.

This commit stabilizes RFC 2008 (rust-lang#44109) by removing the feature gate. Signed-off-by: David Wood <david@davidtw.co>

davidtwco · 2019-10-25T08:34:36Z

Rebased atop #65414 having landed.

Centril

Thanks! r=me when green

davidtwco · 2019-10-25T11:09:22Z

@bors r=Centril

bors · 2019-10-25T11:09:24Z

📌 Commit e0590ea has been approved by Centril

@Centril

…=Centril Stabilize `#[non_exhaustive]` (RFC 2008) Fixes rust-lang#44109. This pull request stabilizes the `#[non_exhaustive]` attribute, which is used to indicate that a type will have more fields / variants added in the future. It can be applied to `struct`s, `enum`s and `enum` variants. See rust-lang#44109 (comment) for the stabilization report. r? @Centril

@ghost

Rollup of 9 pull requests Successful merges: - #64639 (Stabilize `#[non_exhaustive]` (RFC 2008)) - #65074 (Fix the start/end byte positions in the compiler JSON output) - #65315 (Intern place projection) - #65685 (Fix check of `statx` and handle EPERM) - #65731 (Prevent unnecessary allocation in PathBuf::set_extension.) - #65740 (Fix default "disable-shortcuts" feature value) - #65787 (move panictry! to where it is used.) - #65789 (move Attribute::with_desugared_doc to librustdoc) - #65790 (move report_invalid_macro_expansion_item to item.rs) Failed merges: r? @ghost

jhpratt · 2019-10-30T20:16:24Z

I see the milestone is listed as 1.40. Don't things like this typically go through beta first?

Mark-Simulacrum · 2019-10-30T20:27:41Z

The current nightly is 1.40, and in about a week we will ship 1.39 to stable, making 1.40 the beta, and as such in ~7 weeks this will land in stable.

jhpratt · 2019-10-30T20:30:23Z

Oh yeah, for some reason I thought we were already on 1.39.

Version 1.40.0 (2019-12-19) =========================== Language -------- - [You can now use tuple `struct`s and tuple `enum` variant's constructors in `const` contexts.][65188] e.g. ```rust pub struct Point(i32, i32); const ORIGIN: Point = { let constructor = Point; constructor(0, 0) }; ``` - [You can now mark `struct`s, `enum`s, and `enum` variants with the `#[non_exhaustive]` attribute to indicate that there may be variants or fields added in the future.][64639] For example this requires adding a wild-card branch (`_ => {}`) to any match statements on a non-exhaustive `enum`. [(RFC 2008)] - [You can now use function-like procedural macros in `extern` blocks and in type positions.][63931] e.g. `type Generated = macro!();` - [Function-like and attribute procedural macros can now emit `macro_rules!` items, so you can now have your macros generate macros.][64035] - [The `meta` pattern matcher in `macro_rules!` now correctly matches the modern attribute syntax.][63674] For example `(#[$m:meta])` now matches `#[attr]`, `#[attr{tokens}]`, `#[attr[tokens]]`, and `#[attr(tokens)]`. Compiler -------- - [Added tier 3 support\* for the `thumbv7neon-unknown-linux-musleabihf` target.][66103] - [Added tier 3 support for the `aarch64-unknown-none-softfloat` target.][64589] - [Added tier 3 support for the `mips64-unknown-linux-muslabi64`, and `mips64el-unknown-linux-muslabi64` targets.][65843] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [The `is_power_of_two` method on unsigned numeric types is now a `const` function.][65092] Stabilized APIs --------------- - [`BTreeMap::get_key_value`] - [`HashMap::get_key_value`] - [`Option::as_deref_mut`] - [`Option::as_deref`] - [`Option::flatten`] - [`UdpSocket::peer_addr`] - [`f32::to_be_bytes`] - [`f32::to_le_bytes`] - [`f32::to_ne_bytes`] - [`f64::to_be_bytes`] - [`f64::to_le_bytes`] - [`f64::to_ne_bytes`] - [`f32::from_be_bytes`] - [`f32::from_le_bytes`] - [`f32::from_ne_bytes`] - [`f64::from_be_bytes`] - [`f64::from_le_bytes`] - [`f64::from_ne_bytes`] - [`mem::take`] - [`slice::repeat`] - [`todo!`] Cargo ----- - [Cargo will now always display warnings, rather than only on fresh builds.][cargo/7450] - [Feature flags (except `--all-features`) passed to a virtual workspace will now produce an error.][cargo/7507] Previously these flags were ignored. - [You can now publish `dev-dependencies` without including a `version`.][cargo/7333] Misc ---- - [You can now specify the `#[cfg(doctest)]` attribute to include an item only when running documentation tests with `rustdoc`.][63803] Compatibility Notes ------------------- - [As previously announced, any previous NLL warnings in the 2015 edition are now hard errors.][64221] - [The `include!` macro will now warn if it failed to include the entire file.][64284] The `include!` macro unintentionally only includes the first _expression_ in a file, and this can be unintuitive. This will become either a hard error in a future release, or the behavior may be fixed to include all expressions as expected. - [Using `#[inline]` on function prototypes and consts now emits a warning under `unused_attribute` lint.][65294] Using `#[inline]` anywhere else inside traits or `extern` blocks now correctly emits a hard error. [65294]: rust-lang/rust#65294 [66103]: rust-lang/rust#66103 [65843]: rust-lang/rust#65843 [65188]: rust-lang/rust#65188 [65092]: rust-lang/rust#65092 [64589]: rust-lang/rust#64589 [64639]: rust-lang/rust#64639 [64221]: rust-lang/rust#64221 [64284]: rust-lang/rust#64284 [63931]: rust-lang/rust#63931 [64035]: rust-lang/rust#64035 [63674]: rust-lang/rust#63674 [63803]: rust-lang/rust#63803 [cargo/7450]: rust-lang/cargo#7450 [cargo/7507]: rust-lang/cargo#7507 [cargo/7525]: rust-lang/cargo#7525 [cargo/7333]: rust-lang/cargo#7333 [(rfc 2008)]: https://rust-lang.github.io/rfcs/2008-non-exhaustive.html [`f32::to_be_bytes`]: https://doc.rust-lang.org/std/primitive.f32.html#method.to_be_bytes [`f32::to_le_bytes`]: https://doc.rust-lang.org/std/primitive.f32.html#method.to_le_bytes [`f32::to_ne_bytes`]: https://doc.rust-lang.org/std/primitive.f32.html#method.to_ne_bytes [`f64::to_be_bytes`]: https://doc.rust-lang.org/std/primitive.f64.html#method.to_be_bytes [`f64::to_le_bytes`]: https://doc.rust-lang.org/std/primitive.f64.html#method.to_le_bytes [`f64::to_ne_bytes`]: https://doc.rust-lang.org/std/primitive.f64.html#method.to_ne_bytes [`f32::from_be_bytes`]: https://doc.rust-lang.org/std/primitive.f32.html#method.from_be_bytes [`f32::from_le_bytes`]: https://doc.rust-lang.org/std/primitive.f32.html#method.from_le_bytes [`f32::from_ne_bytes`]: https://doc.rust-lang.org/std/primitive.f32.html#method.from_ne_bytes [`f64::from_be_bytes`]: https://doc.rust-lang.org/std/primitive.f64.html#method.from_be_bytes [`f64::from_le_bytes`]: https://doc.rust-lang.org/std/primitive.f64.html#method.from_le_bytes [`f64::from_ne_bytes`]: https://doc.rust-lang.org/std/primitive.f64.html#method.from_ne_bytes [`option::flatten`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.flatten [`option::as_deref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_deref [`option::as_deref_mut`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_deref_mut [`hashmap::get_key_value`]: https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.get_key_value [`btreemap::get_key_value`]: https://doc.rust-lang.org/std/collections/struct.BTreeMap.html#method.get_key_value [`slice::repeat`]: https://doc.rust-lang.org/std/primitive.slice.html#method.repeat [`mem::take`]: https://doc.rust-lang.org/std/mem/fn.take.html [`udpsocket::peer_addr`]: https://doc.rust-lang.org/std/net/struct.UdpSocket.html#method.peer_addr [`todo!`]: https://doc.rust-lang.org/std/macro.todo.html

rust-highfive assigned Centril Sep 20, 2019

This comment has been minimized.

Sign in to view

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2019

davidtwco mentioned this pull request Sep 20, 2019

Tracking issue for RFC 2008: Future-proofing enums/structs with #[non_exhaustive] attribute #44109

Closed

7 tasks

jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 20, 2019

jonas-schievink added this to the 1.40 milestone Sep 20, 2019

scottmcm added the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Sep 20, 2019

Centril reviewed Sep 21, 2019

View reviewed changes

src/libsyntax/feature_gate/accepted.rs Outdated Show resolved Hide resolved

src/libsyntax/feature_gate/builtin_attrs.rs Outdated Show resolved Hide resolved

Centril added T-lang Relevant to the language team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 21, 2019

davidtwco force-pushed the rfc-2008-stabilization branch from 847b77b to 125f483 Compare September 21, 2019 20:26

Centril removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 21, 2019

This comment has been minimized.

Sign in to view

Centril changed the title ~~RFC 2008: Stabilization~~ Stabilize #[non_exhaustive] (RFC 2008) Sep 21, 2019

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 1, 2019

davidtwco force-pushed the rfc-2008-stabilization branch from 125f483 to 62e0fb2 Compare October 1, 2019 15:42

davidtwco added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2019

davidtwco force-pushed the rfc-2008-stabilization branch from 62e0fb2 to d5b1d47 Compare October 6, 2019 09:04

Centril added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2019

This comment has been minimized.

Sign in to view

davidtwco force-pushed the rfc-2008-stabilization branch from d5b1d47 to 23fd40f Compare October 14, 2019 19:48

davidtwco mentioned this pull request Oct 24, 2019

ignore uninhabited non-exhaustive variant fields #65414

Merged

Centril added F-non_exhaustive `#![feature(non_exhaustive)]` S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 25, 2019

RFC 2008: Stabilization

e0590ea

This commit stabilizes RFC 2008 (rust-lang#44109) by removing the feature gate. Signed-off-by: David Wood <david@davidtw.co>

davidtwco force-pushed the rfc-2008-stabilization branch from 23fd40f to e0590ea Compare October 25, 2019 08:34

davidtwco added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2019

Centril approved these changes Oct 25, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2019

Centril mentioned this pull request Oct 25, 2019

Rollup of 9 pull requests #65804

Merged

bors merged commit e0590ea into rust-lang:master Oct 25, 2019

Centril mentioned this pull request Oct 25, 2019

Add non_exhaustive to reference. rust-lang/reference#609

Merged

davidtwco deleted the rfc-2008-stabilization branch October 25, 2019 14:44

tikue mentioned this pull request Oct 30, 2019

Reintroduce #[non_exhaustive] google/tarpc#275

Closed

pnkfelix mentioned this pull request Nov 29, 2019

Handle non_exhaustive in borrow checking #66722

Merged

upsuper mentioned this pull request Nov 1, 2020

No autocomplete for #[non_exhaustive] intellij-rust/intellij-rust#6334

Closed

Be-ing mentioned this pull request Oct 22, 2022

handle file paths to libraries rust-lang/pkg-config-rs#134

Merged

Stabilize #[non_exhaustive] (RFC 2008) #64639

Stabilize #[non_exhaustive] (RFC 2008) #64639

Uh oh!

Conversation

davidtwco commented Sep 20, 2019 • edited by Centril Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Centril left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

davidtwco commented Oct 6, 2019

Uh oh!

Centril commented Oct 6, 2019

Uh oh!

This comment has been minimized.

Centril commented Oct 25, 2019

Uh oh!

davidtwco commented Oct 25, 2019

Uh oh!

Centril left a comment

Choose a reason for hiding this comment

Uh oh!

davidtwco commented Oct 25, 2019

Uh oh!

bors commented Oct 25, 2019

Uh oh!

jhpratt commented Oct 30, 2019

Uh oh!

Mark-Simulacrum commented Oct 30, 2019

Uh oh!

jhpratt commented Oct 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Stabilize `#[non_exhaustive]` (RFC 2008) #64639

Stabilize `#[non_exhaustive]` (RFC 2008) #64639

davidtwco commented Sep 20, 2019 •

edited by Centril

Loading