Skip to content

Add Compatibility Notes to RELEASES.md for 1.38.0 #64621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2019
Merged

Add Compatibility Notes to RELEASES.md for 1.38.0 #64621

merged 1 commit into from
Sep 21, 2019

Conversation

@XAMPPRocky
Copy link
Contributor

@XAMPPRocky XAMPPRocky commented Sep 19, 2019 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2019
jonas-schievink
jonas-schievink reviewed Sep 19, 2019
View reviewed changes
@jonas-schievink
Copy link
Contributor

The rendered link points to the wrong branch

@XAMPPRocky XAMPPRocky changed the title Add Compatibility Notes to RELEASES.md for 1.39.0 Add Compatibility Notes to RELEASES.md for 1.38.0 Sep 19, 2019
@XAMPPRocky
Copy link
Contributor Author

It also wasn't for 1.39.0. It's late.

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

(It's mostly important that this gets into beta, though, so this landing in master is not super high priority. Can be rolled up).

@bors
Copy link
Collaborator

bors commented Sep 19, 2019

📌 Commit 3db2c13 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2019
@Mark-Simulacrum Mark-Simulacrum added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2019
@Centril
Copy link
Contributor

Centril commented Sep 20, 2019

@bors p=0 rollup=always

Centril added a commit to Centril/rust that referenced this pull request Sep 20, 2019
@Centril
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
5c610c8 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Sep 20, 2019
Closed
bors added a commit that referenced this pull request Sep 20, 2019
@bors
Auto merge of #64626 - Centril:rollup-elbvzz0, r=Centril
c59bea3 
Rollup of 8 pull requests

Successful merges:

 - #64136 (Document From trait for LhsExpr in parser)
 - #64342 (factor out pluralisation remains after #64280)
 - #64387 (Fix redundant semicolon lint interaction with proc macro attributes)
 - #64498 (When possible point at argument causing item obligation failure)
 - #64615 (rustbuild: Turn down compression on exe installers)
 - #64617 (rustbuild: Turn down compression on msi installers)
 - #64618 (rustbuild: Improve output of `dist` step)
 - #64621 (Add Compatibility Notes to RELEASES.md for 1.38.0)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 20, 2019
@Centril
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
3f4f41d 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
@tmandry
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
230ccf6 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@tmandry tmandry mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
@tmandry
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
4140eda 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@tmandry tmandry mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
@tmandry
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
5e71a79 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@tmandry tmandry mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
@tmandry
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
18417c8 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@tmandry tmandry mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 21, 2019
@tmandry
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
558f84c 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@tmandry tmandry mentioned this pull request Sep 21, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
@Centril
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
fefbcd5 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Sep 21, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
@Centril
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
6da43dd 
Add Compatibility Notes to RELEASES.md for 1.38.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md)

r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Sep 21, 2019
Merged
bors added a commit that referenced this pull request Sep 21, 2019
@bors
Auto merge of #64658 - Centril:rollup-9s3raz6, r=Centril
ed8b708 
Rollup of 9 pull requests

Successful merges:

 - #64010 (Stabilize `param_attrs` in Rust 1.39.0)
 - #64136 (Document From trait for LhsExpr in parser)
 - #64342 (factor out pluralisation remains after #64280)
 - #64347 (Add long error explanation for E0312)
 - #64621 (Add Compatibility Notes to RELEASES.md for 1.38.0)
 - #64632 (remove the extra comma after the match arm)
 - #64640 (No home directory on vxWorks)
 - #64641 (Exempt extern "Rust" from improper_ctypes)
 - #64642 (Fix the span used to suggest avoiding for-loop moves)

Failed merges:

r? @ghost
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 21, 2019
Merged
@bors bors merged commit 3db2c13 into rust-lang:master Sep 21, 2019
@XAMPPRocky XAMPPRocky deleted the relnotes branch September 21, 2019 18:38
bors added a commit that referenced this pull request Sep 21, 2019
@bors
Auto merge of #64661 - Mark-Simulacrum:beta-next, r=Mark-Simulacrum
1c65325 
[beta] rollup of last set of backports

* ci: split aws credentials in two separate users with scoped perms #64576
* Updated RELEASES.md for 1.38.0 #64283
* Add Compatibility Notes to RELEASES.md for 1.38.0 #64621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonas-schievink jonas-schievink jonas-schievink left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XAMPPRocky @jonas-schievink @Mark-Simulacrum @bors @Centril @rust-highfive