Run Clippy without json-rendered flag

[mati865]

Removed in #62766

Replacing it with --json=diagnostic-rendered-ansi fails:

error: using `--json` requires also using `--error-format=json`

Running ./x.py clippy src/libstd locally works fine (with colors) on Linux so I don't know if there is something to fix.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[mati865]

r? @oli-obk

[Mark-Simulacrum]

cc @ehuss/@alexcrichton

[oli-obk]

Please keep colors by adding both --json=diagnostic-rendered-ansi and --error-format=json

[mati865]

@oli-obk I tried it before and it didn't work:

$ ./x.py clippy src/libstd                    
Updating only changed submodules
Submodules updated in 0.02 seconds
   Compiling bootstrap v0.0.0 (/home/mateusz/Projects/rust/rust/src/bootstrap)
    Finished dev [unoptimized] target(s) in 6.40s
Checking std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Checking core v0.0.0 (/home/mateusz/Projects/rust/rust/src/libcore)
   Compiling compiler_builtins v0.1.18
   Compiling libc v0.2.60
error: Option 'error-format' given more than once

error: Could not compile `core`.
warning: build failed, waiting for other jobs to finish...
error: build failed
command did not execute successfully: "/home/mateusz/Projects/rust/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "clippy" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/home/mateusz/Projects/rust/rust/src/libstd/Cargo.toml" "--message-format" "json-render-diagnostics" "--" "--cap-lints" "warn"
expected success, got: exit code: 101
failed to run: /home/mateusz/Projects/rust/rust/build/bootstrap/debug/bootstrap clippy src/libstd

diff

diff --git a/src/bootstrap/builder.rs b/src/bootstrap/builder.rs
index 4e49aaa16ea..3a5901156b4 100644
--- a/src/bootstrap/builder.rs
+++ b/src/bootstrap/builder.rs
@@ -875,7 +875,8 @@ impl<'a> Builder<'a> {
         }
 
         if cmd == "clippy" {
-            extra_args.push_str("-Zforce-unstable-if-unmarked");
+            extra_args.push_str("-Zforce-unstable-if-unmarked \
+            --json=diagnostic-rendered-ansi --error-format=json");
         }
 
         if !extra_args.is_empty() {

[oli-obk]

Huh I thought we had a setup to allow error-format to be passed multiple times, because cargo also sets it twice sometimes. Maybe the bootstrap cargo is too old?

[mati865]

Using cargo 1.39.0-nightly (3f700ec43 2019-08-19) fails with the same error.

[ehuss]

Please keep colors by adding both --json=diagnostic-rendered-ansi and --error-format=json

I'm not sure I understand this (colors should work fine). cargo clippy is just a wrapper around cargo check. The --message-format flag (set in stream_cargo) tells cargo how to set these now, so this PR should be good.

[oli-obk]

Ah, wonderful

@bors r=oli-obk,ehuss

[bors]

📌 Commit 5cf43bd has been approved by oli-obk,ehuss