Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore: Readd /tmp/ #63429

Merged
merged 3 commits into from
Aug 10, 2019
Merged

.gitignore: Readd /tmp/ #63429

merged 3 commits into from
Aug 10, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Aug 10, 2019

Specifically, /tmp/partitioning-tests/ it is generated by the incremental tests, https://github.com/rust-lang/rust/search?p=2&q=partitioning-tests&unscoped_q=partitioning-tests. These are cleaned up by compiletest but not if you kill testing prematurely (which I just did to test out a rollup, and it is annoying to rm -rf tmp/).

r? @Mark-Simulacrum
cc @RalfJung

It is produced during `./x.py test`
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2019
@Centril
Copy link
Contributor Author

Centril commented Aug 10, 2019

@bors rollup

.gitignore Show resolved Hide resolved
@RalfJung
Copy link
Member

RalfJung commented Aug 10, 2019

Would be great if you could also add a comment for obj: #63373 (comment) :)

@Centril
Copy link
Contributor Author

Centril commented Aug 10, 2019

@RalfJung Done :)

Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd say r=me but I feel this is outside my jurisdiction.^^

@Mark-Simulacrum
Copy link
Member

@bors r+

I think .gitignore is both outside and inside everyone's jurisdiction.. tragedy of the commons and all.

@bors
Copy link
Contributor

bors commented Aug 10, 2019

📌 Commit 83b837a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2019
@petrochenkov
Copy link
Contributor

FYI, there's an issue about removing this tmp - #34586.

@Centril
Copy link
Contributor Author

Centril commented Aug 10, 2019

@petrochenkov Thanks for the cc; Let's remove it again when it isn't produced anymore :)

Centril added a commit to Centril/rust that referenced this pull request Aug 10, 2019
…rk-Simulacrum

.gitignore: Readd `/tmp/`

Specifically, `/tmp/partitioning-tests/` it is generated by the incremental tests, https://github.com/rust-lang/rust/search?p=2&q=partitioning-tests&unscoped_q=partitioning-tests. These are cleaned up by compiletest but not if you kill testing prematurely (which I just did to test out a rollup, and it is annoying to `rm -rf tmp/`).

r? @Mark-Simulacrum
cc @RalfJung
bors added a commit that referenced this pull request Aug 10, 2019
Rollup of 4 pull requests

Successful merges:

 - #63400 (Try to break resolve into more isolated parts)
 - #63425 (Cleanup historical stability comments)
 - #63429 (.gitignore: Readd `/tmp/`)
 - #63432 (Cleanup & Simplify stuff in lowering)

Failed merges:

r? @ghost
@bors bors merged commit 83b837a into master Aug 10, 2019
@Centril Centril deleted the gitignore-readd-tmp branch August 10, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants