vim file improvements #6259
Merged
vim file improvements #6259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like these changes, but could you do a rebase rather than a merge for that last commit? |
|
Super big r+ on this, I've been meaning to change my |
added 2 commits
May 8, 2013 11:16
Makes colorcolumn setlocal instead of set. Makes conceal opt-in. Removes the seem-to-be obsolete old keywords/types
|
Rebased to remove merge commit. r+? |
bors
added a commit
that referenced
this pull request
May 8, 2013
`colorcolumn` is now set with `setlocal`, so it doesn't infect the entire session. `conceal` support is now opt-in, not opt-out. I haven't found anybody that likes it or cares either way. The indent file now uses `cindent` with appropriate `cinoptions` and `cinkeys`. Auto-indenting an entire file mostly gets the right thing now, with structs and enums not being affects like before. Defaults to the hanging indent style, unless the first argument is on a new line. There were some keywords in the syntax file that I've never seen (and have been used as identifiers in some tests) so they have been commented out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colorcolumnis now set withsetlocal, so it doesn't infect the entire session.concealsupport is now opt-in, not opt-out. I haven't found anybody that likes it or cares either way.The indent file now uses
cindentwith appropriatecinoptionsandcinkeys. Auto-indenting an entire file mostly gets the right thing now, with structs and enums not being affects like before. Defaults to the hanging indent style, unless the first argument is on a new line.There were some keywords in the syntax file that I've never seen (and have been used as identifiers in some tests) so they have been commented out.