Improvements to mkdir_recursive #6107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking whether the parent is "." or "/", check the number of components. Also, more tests.
bors
added a commit
that referenced
this pull request
Apr 30, 2013
r? @brson This hopefully addresses your concerns about the termination condition, and adds more tests. With a bonus documentation commit.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 24, 2020
…e, r=flip1995 Ref style link false positive This PR does not fix rust-lang#5834, but it records the problematic link text as a **known problem** inside `doc_markdown` lint. r? `@flip1995` - [ ] Followed [lint naming conventions][lint_naming] - [ ] Added passing UI tests (including committed `.stderr` file) - [x] `cargo test` passes locally - [x] Executed `cargo dev update_lints` - [ ] Added lint documentation - [x] Run `cargo dev fmt` --- *Please keep the line below* changelog: Document problematic link text style as known problem for `doc_markdown`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson This hopefully addresses your concerns about the termination condition, and adds more tests. With a bonus documentation commit.