Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest removing ? to resolve type errors. #59859

Merged
merged 2 commits into from
Apr 13, 2019
Merged

Conversation

davidtwco
Copy link
Member

Fixes #59756.

This commit adds a test that demonstrates the compiler's current
behaviour when a function attempts to return a value that was unwrapped
by a `?` operator when the omission of `?` would have made the code
compile.
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2019
This commit adds a suggestion to remove the `?` from expressions if
removing the `?` would resolve a type error.
@cramertj
Copy link
Member

@bors r? @cramertj
@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2019

📌 Commit 16592f6 has been approved by cramertj

@rust-highfive rust-highfive assigned cramertj and unassigned oli-obk Apr 10, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 12, 2019
Suggest removing `?` to resolve type errors.

Fixes rust-lang#59756.
bors added a commit that referenced this pull request Apr 13, 2019
Rollup of 8 pull requests

Successful merges:

 - #59781 (Remove check_match from const_eval)
 - #59820 (proc_macro: stop using LEB128 for RPC.)
 - #59846 (clarify what the item is in "not a module" error)
 - #59847 (Error when using `catch` after `try`)
 - #59859 (Suggest removing `?` to resolve type errors.)
 - #59862 (Tweak unstable diagnostic output)
 - #59866 (Recover from missing semicolon based on the found token)
 - #59892 (Impl RawFd conversion traits for WASI TcpListener, TcpStream and UdpSocket)

Failed merges:

r? @ghost
@bors bors merged commit 16592f6 into rust-lang:master Apr 13, 2019
@davidtwco davidtwco deleted the issue-59756 branch April 14, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion to remove ?
5 participants