Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug assertions to write_bytes and copy* #58783

Closed
wants to merge 7 commits into from
Closed

Add debug assertions to write_bytes and copy* #58783

wants to merge 7 commits into from

Conversation

nitnelave
Copy link
Contributor

This is a followup of #57997 to address #53871

We check that:

  • write_bytes has an aligned pointer
  • copy has both aligned pointers and the end of src isn't in dst (otherwise we overwrite something before reading it)
  • copy_nonoverlapping has both aligned pointers and src and dst don't overlap.

@rust-highfive
Copy link
Collaborator

r? @bluss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2019
@nitnelave
Copy link
Contributor Author

r? @RalfJung

@rust-highfive rust-highfive assigned RalfJung and unassigned bluss Feb 27, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:272c64d4:start=1551284196264054014,finish=1551284197214879683,duration=950825669
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:52] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:52] tidy error: /checkout/src/libcore/intrinsics.rs:1514: line longer than 100 chars
[00:03:54] some tidy checks failed
[00:03:54] 
[00:03:54] 
[00:03:54] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:54] 
[00:03:54] 
[00:03:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:54] Build completed unsuccessfully in 0:00:48
[00:03:54] Build completed unsuccessfully in 0:00:48
[00:03:54] make: *** [tidy] Error 1
[00:03:54] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:16491a40
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Feb 27 16:20:43 UTC 2019
---
travis_time:end:009491f3:start=1551284444169764037,finish=1551284444175804930,duration=6040893
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:015ceb52
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:264ae4f9
travis_time:start:264ae4f9
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:09f4b64e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:000c9ac8:start=1551285321451041446,finish=1551285335930360595,duration=14479319149
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:47:37] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:47:37] 
[00:47:37] note: rustc 1.34.0-dev running on x86_64-unknown-linux-gnu
[00:47:37] 
[00:47:37] note: compiler flags: -Z force-unstable-if-unmarked -C opt-level=2 -C prefer-dynamic -C debug-assertions=y -C codegen-units=1 -C link-args=-Wl,-rpath,$ORIGIN/../lib --crate-type lib
[00:47:37] note: some of the compiler flags provided by cargo are hidden
[00:47:37] 
[00:47:37] error: Could not compile `core`.
[00:47:37]

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nitnelave
Copy link
Contributor Author

Looks like something broke, we have a (questionably) invalid call to copy with src overlapping with dst. I'm investigating.

RalfJung
RalfJung reviewed Feb 27, 2019
View reviewed changes
src/libcore/intrinsics.rs Outdated Show resolved Hide resolved
RalfJung
RalfJung reviewed Feb 27, 2019
View reviewed changes
src/libcore/intrinsics.rs Outdated
Ordering::Greater => dst_usize + size > src_usize,
// src == dst
Ordering::Equal => count != 0,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, Miri will not like this... but yeah this seems right. Cc @oli-obk

@RalfJung
Copy link
Member

Uh nice, maybe we found the first bug already? :D

@nitnelave
Copy link
Contributor Author

While building the compiler, I got an error on a vector.clone() that triggered the overlapping part of copy-nonoverlapping. I'm having a look, but I'm not super familiar with the code, so it might take me a while.

@RalfJung
Copy link
Member

Do you have a backtrace?

@nitnelave
Copy link
Contributor Author

nitnelave commented Feb 27, 2019 via email

ollie27
ollie27 reviewed Feb 27, 2019
View reviewed changes
src/libcore/intrinsics.rs Outdated Show resolved Hide resolved
ollie27
ollie27 reviewed Feb 27, 2019
View reviewed changes
src/libcore/intrinsics.rs Outdated Show resolved Hide resolved
RalfJung
RalfJung reviewed Feb 27, 2019
View reviewed changes
src/libcore/intrinsics.rs Outdated Show resolved Hide resolved
@nitnelave
Copy link
Contributor Author

The stacktrace looks like this (trimmed to the relevant part):

10: core::slice::<impl [T]>::copy_from_slice         
             at ./src/libcore/macros.rs:11                                          
             at ./src/libcore/slice/mod.rs:1971                     
  11: <alloc::vec::Vec<T> as core::clone::Clone>::clone                          
             at ./src/liballoc/vec.rs:1915                                                                                                        
             at ./src/liballoc/vec.rs:1351                        
             at ./src/liballoc/slice.rs:160               
             at ./src/liballoc/slice.rs:380        
             at ./src/liballoc/vec.rs:1642                                                                                                           
 12: <rustc::traits::Vtable<'tcx, N> as core::clone::Clone>::clone             
             at src/librustc/traits/mod.rs:569                                  
             at src/librustc/traits/mod.rs:520                                  
  13: rustc::ty::erase_regions::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::erase_regions
             at src/librustc/ty/erase_regions.rs:26                                                 
  14: rustc::traits::codegen::<impl rustc::infer::InferCtxt<'a, 'gcx, 'tcx>>::drain_fulfillment_cx_or_panic
             at src/librustc/traits/codegen/mod.rs:161 
  15: rustc::ty::context::GlobalCtxt::enter_local                                                                                                               at src/librustc/traits/codegen/mod.rs:72                                                                                                           at src/librustc/infer/mod.rs:522                                                                  
             at src/librustc/ty/context.rs:1727                 
             at src/librustc/ty/context.rs:1966                                                                                                   
             at src/librustc/ty/context.rs:1899          
             at src/librustc/ty/context.rs:1965        
             at src/librustc/ty/context.rs:1726                                                                                                    
             at src/librustc/ty/context.rs:2072

@RalfJung
Copy link
Member

10: core::slice::<impl [T]>::copy_from_slice

That function calls copy_nonoverlapping, so might be a real bug?

@nitnelave nitnelave mentioned this pull request Feb 28, 2019
Closed
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:30319caa:start=1551365512097169172,finish=1551365657099576484,duration=145002407312
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:27:02] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:27:02] 
[00:27:02] note: rustc 1.34.0-dev running on x86_64-unknown-linux-gnu
[00:27:02] 
[00:27:02] note: compiler flags: -Z force-unstable-if-unmarked -C opt-level=2 -C prefer-dynamic -C debug-assertions=y -C link-args=-Wl,-rpath,$ORIGIN/../lib --crate-type lib
[00:27:02] note: some of the compiler flags provided by cargo are hidden
[00:27:02] 
[00:27:02] error: Could not compile `rustc_apfloat`.
[00:27:02] warning: build failed, waiting for other jobs to finish...
---
145228 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu
145224 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release
142404 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps
141172 ./obj/build/bootstrap/debug/incremental/bootstrap-3i6jt5nchoxcn
141168 ./obj/build/bootstrap/debug/incremental/bootstrap-3i6jt5nchoxcn/s-f9wvmfulbl-lx0qp8-okq6jwyp562e
108528 ./src/llvm-project/lldb
97552 ./src/llvm-project/clang/test
89964 ./src/llvm-emscripten/test/CodeGen
78764 ./.git/modules
---
travis_time:end:010c1b2c:start=1551367295329126399,finish=1551367295333786765,duration=4660366
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2042fa48
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
t

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

ping from triage @nitnelave you have to fix the failing tests

@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2019
@RalfJung
Copy link
Member

RalfJung commented Mar 18, 2019 •
edited
Loading

The failure occurs in Vec::clone:

    fn clone(&self) -> Vec<T> {
        <[T]>::to_vec(&**self)
    }

I find it highly unlikely that there are indeed overlapping references here (and I think Miri would have found them), so my guess is that the check is wrong. OTOH, it looks all right... maybe try adding debug printing to overlaps?

If you do x.py --stage 0 test src/liballoc --no-doc, do you get test failures? That will build libstd but not the compiler, so you shouldn't run into the problem above.

RalfJung
RalfJung reviewed Mar 18, 2019
View reviewed changes
src/libcore/intrinsics.rs Outdated
use crate::cmp::Ordering;
let src_usize = src as usize;
let dst_usize = dst as usize;
let size = mem::size_of::<T>() * count;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use checked arithmetic here? Overflow should always panic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, doing that.

@nitnelave
Copy link
Contributor Author

No, I don't get failures on x.py --stage 0 test src/liballoc. I'd love to blame it on the check, but I checked it again and can't see the issue :/

@RalfJung
Copy link
Member

Well, then I guess you'll have to resort to printf debugging. :/

Let me know when you are stuck or need assistance.

@ollie27
Copy link
Member

ollie27 commented Mar 18, 2019

I think the failure from #58783 (comment) was caused by the error I pointed out in #58783 (comment) because before that was fixed there was a false positive from slices of ZSTs. I think we need a new backtrace.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:040afaa4:start=1556344319110075927,finish=1556344319888331061,duration=778255134
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:01:56] extracting /checkout/obj/build/cache/2019-04-11/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:56] error: failed to resolve patches for `https://github.com/rust-lang/cargo`
[00:01:56] 
[00:01:56] Caused by:
[00:01:56]   patch for `cargo` in `https://github.com/rust-lang/cargo` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:01:56] Build completed unsuccessfully in 0:00:14
[00:01:56] Makefile:69: recipe for target 'prepare' failed
[00:01:56] make: *** [prepare] Error 1
[00:01:57] Command failed. Attempt 2/5:
[00:01:57] Command failed. Attempt 2/5:
[00:01:57] error: failed to resolve patches for `https://github.com/rust-lang/cargo`
[00:01:57] 
[00:01:57] Caused by:
[00:01:57]   patch for `cargo` in `https://github.com/rust-lang/cargo` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:01:57] Build completed unsuccessfully in 0:00:00
[00:01:57] make: *** [prepare] Error 1
[00:01:57] Makefile:69: recipe for target 'prepare' failed
[00:01:59] Command failed. Attempt 3/5:
[00:01:59] Command failed. Attempt 3/5:
[00:01:59] error: failed to resolve patches for `https://github.com/rust-lang/cargo`
[00:01:59] 
[00:01:59] Caused by:
[00:01:59]   patch for `cargo` in `https://github.com/rust-lang/cargo` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:01:59] Build completed unsuccessfully in 0:00:00
[00:01:59] Makefile:69: recipe for target 'prepare' failed
[00:01:59] make: *** [prepare] Error 1
[00:02:02] Command failed. Attempt 4/5:
[00:02:02] Command failed. Attempt 4/5:
[00:02:02] error: failed to resolve patches for `https://github.com/rust-lang/cargo`
[00:02:02] 
[00:02:02] Caused by:
[00:02:02]   patch for `cargo` in `https://github.com/rust-lang/cargo` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:02:02] Build completed unsuccessfully in 0:00:00
[00:02:02] make: *** [prepare] Error 1
[00:02:02] Makefile:69: recipe for target 'prepare' failed
[00:02:06] Command failed. Attempt 5/5:
[00:02:06] Command failed. Attempt 5/5:
[00:02:06] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:02:06] 
[00:02:06] Caused by:
[00:02:06]   patch for `rustfmt-nightly` in `https://github.com/rust-lang/crates.io-index` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:02:06] Build completed unsuccessfully in 0:00:00
[00:02:06] Makefile:69: recipe for target 'prepare' failed
[00:02:06] The command has failed after 5 attempts.
[00:02:06] make: *** [prepare] Error 1
---
travis_time:end:009498d2:start=1556344461575334217,finish=1556344461580946517,duration=5612300
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a0c82bc
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:114d4d90
travis_time:start:114d4d90
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:047a23ba
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Apr 29, 2019

☔ The latest upstream changes (presumably #60355) made this pull request unmergeable. Please resolve the merge conflicts.

@RalfJung
Copy link
Member

@nitnelave what is the status of this? Something went very wrong in the last rebase, you now have tons of submodule changes in this PR.

@nitnelave
Copy link
Contributor Author

nitnelave commented Apr 30, 2019 via email

@RalfJung
Copy link
Member

RalfJung commented Jun 3, 2019

@nitnelave any updates on this?

@Dylan-DPC-zz
Copy link

ping from triage @nitnelave
Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again! Thanks

@Dylan-DPC-zz Dylan-DPC-zz added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2019
@RalfJung RalfJung mentioned this pull request Jun 24, 2019
Merged
@RalfJung
Copy link
Member

Re-submitted as #62103.

@nitnelave
Copy link
Contributor Author

Sorry about that, life got in the way :(

@RalfJung
Copy link
Member

That's okay, and thanks for your work! I didn't have to do much any more. :)

Centril added a commit to Centril/rust that referenced this pull request Jun 26, 2019
@Centril
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
adb4d4a 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
@Centril
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
e14989b 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
@Centril
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
215e422 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2019
@Manishearth
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
7982092 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 3, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
3b3ff6e 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
Centril added a commit to Centril/rust that referenced this pull request Jul 4, 2019
@Centril
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
ddad16b 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
7bae0b7 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
b208172 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
@RalfJung RalfJung mentioned this pull request Jul 7, 2019
Merged
bors added a commit that referenced this pull request Jul 9, 2019
@bors
Auto merge of #62460 - RalfJung:llvm-null, r=eddyb
8895384 
 Handle null from LLVMRustGetSectionName

As part of #58783 and #62103, this incorrect use of a NULL pointer was found in the interface to LLVM. That PR is stuck with some linker issues, but there is no reason the soundness fix should have to wait for that.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 15, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
f940617 
Add debug assertions to write_bytes and copy*

Looks like @nitnelave  went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship.

Cc rust-lang#53871
djrenren pushed a commit to djrenren/compiletest that referenced this pull request Aug 26, 2019
@bors
Auto merge of #59990 - bjorn3:nicer_compiletest_errors, r=alexcrichton
c49a974 
Use resume_unwind instead of panic!() for nicer compiletest errors

cc rust-lang/rust#58783 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brolock Brolock Brolock left review comments

@ollie27 ollie27 ollie27 left review comments

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.