Refactor generic parameter encoder functions #58581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This was referenced Feb 19, 2019
|
☔ The latest upstream changes (presumably #58561) made this pull request unmergeable. Please resolve the merge conflicts. |
eddyb
reviewed
Feb 26, 2019
eddyb
reviewed
Feb 26, 2019
varkor
force-pushed
the
const-generics-encoder-refactor
branch
from
ed15945
to
2423219
Compare
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
const-generics-encoder-refactor
branch
from
7dc5060
to
2423219
Compare
16 tasks
varkor
force-pushed
the
const-generics-encoder-refactor
branch
from
2423219
to
6217ee1
Compare
|
I've updated to take account of the different kinds. |
eddyb
approved these changes
Mar 26, 2019
|
@bors r+ |
|
📌 Commit 6217ee1 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 27, 2019
…tor, r=eddyb Refactor generic parameter encoder functions Addresses rust-lang#58503 (comment). r? @eddyb
|
Speculatively assigning blame of failure in #59457 (comment). @bors r- |
bors
added
S-waiting-on-author
|
I'll rebase on top of #59466 and we'll see. |
|
You may be vindicated -- #59466 (comment) failed the same way. |
|
@bors r=eddyb rollup |
|
📌 Commit 6217ee1 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 28, 2019
…tor, r=eddyb Refactor generic parameter encoder functions Addresses rust-lang#58503 (comment). r? @eddyb
bors
added a commit
that referenced
this pull request
Mar 28, 2019
Rollup of 12 pull requests Successful merges: - #57987 (Fix some AArch64 typos) - #58581 (Refactor generic parameter encoder functions) - #58803 (fs::copy() unix: set file mode early) - #58848 (Prevent cache issues on version updates) - #59198 (Do not complain about unmentioned fields in recovered patterns) - #59351 (Include llvm-ar with llvm-tools component) - #59413 (HirIdify hir::ItemId) - #59441 (Remove the block on natvis for lld-link.) - #59448 (Use consistent phrasing for all macro summaries) - #59456 (Add documentation about `for` used as higher ranked trait bounds) - #59472 (Document that `std::io::BufReader` discards contents on drop) - #59474 (Fix link capitalization in documentation of std::io::BufWriter.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #58503 (comment).
r? @eddyb