std: Stabilize fixed-width integer atomics #57425

alexcrichton · 2019-01-07T20:46:25Z

This commit stabilizes the Atomic{I,U}{8,16,32,64} APIs in the
std::sync::atomic and core::sync::atomic modules. Proposed in #56753
and tracked in #32976 this feature has been unstable for quite some time
and is hopefully ready to go over the finish line now!

The API is being stabilized as-is. The API of AtomicU8 and friends
mirrors that of AtomicUsize. A list of changes made here are:

A portability documentation section has been added to describe the
current state of affairs.
Emulation of smaller-size atomics with larger-size atomics has been
documented.
As an added bonus, ATOMIC_*_INIT is now scheduled for deprecation
across the board in 1.34.0 now that const functions can be invoked
in statics.

Note that the 128-bit atomic types are omitted from this stabilization
explicitly. They have far less platform support than the other atomic
types, and will likely require further discussion about their best
location.

Closes #32976
Closes #56753

alexcrichton · 2019-01-07T20:47:10Z

Note that this is currently still blocked on the FCP in #56753, so this shouldn't be approved until that FCP has finished.

src/libcore/sync/atomic.rs

alexcrichton · 2019-01-08T22:17:53Z

r? @sfackler

(for eventual stabilization)

src/libcore/sync/atomic.rs

Centril · 2019-01-25T17:10:30Z

Ping from triage @alexcrichton and @sfackler :)

This commit stabilizes the `Atomic{I,U}{8,16,32,64}` APIs in the `std::sync::atomic` and `core::sync::atomic` modules. Proposed in rust-lang#56753 and tracked in rust-lang#32976 this feature has been unstable for quite some time and is hopefully ready to go over the finish line now! The API is being stabilized as-is. The API of `AtomicU8` and friends mirrors that of `AtomicUsize`. A list of changes made here are: * A portability documentation section has been added to describe the current state of affairs. * Emulation of smaller-size atomics with larger-size atomics has been documented. * As an added bonus, `ATOMIC_*_INIT` is now scheduled for deprecation across the board in 1.34.0 now that `const` functions can be invoked in statics. Note that the 128-bit atomic types are omitted from this stabilization explicitly. They have far less platform support than the other atomic types, and will likely require further discussion about their best location. Closes rust-lang#32976 Closes rust-lang#56753

alexcrichton · 2019-01-25T19:48:37Z

Oops, thanks for the ping!

@bors: r=sfackler

bors · 2019-01-25T19:48:38Z

📌 Commit 14b36fb has been approved by sfackler

…fackler std: Stabilize fixed-width integer atomics This commit stabilizes the `Atomic{I,U}{8,16,32,64}` APIs in the `std::sync::atomic` and `core::sync::atomic` modules. Proposed in rust-lang#56753 and tracked in rust-lang#32976 this feature has been unstable for quite some time and is hopefully ready to go over the finish line now! The API is being stabilized as-is. The API of `AtomicU8` and friends mirrors that of `AtomicUsize`. A list of changes made here are: * A portability documentation section has been added to describe the current state of affairs. * Emulation of smaller-size atomics with larger-size atomics has been documented. * As an added bonus, `ATOMIC_*_INIT` is now scheduled for deprecation across the board in 1.34.0 now that `const` functions can be invoked in statics. Note that the 128-bit atomic types are omitted from this stabilization explicitly. They have far less platform support than the other atomic types, and will likely require further discussion about their best location. Closes rust-lang#32976 Closes rust-lang#56753

bors · 2019-01-26T09:46:18Z

⌛ Testing commit 14b36fb with merge f95834b...

std: Stabilize fixed-width integer atomics This commit stabilizes the `Atomic{I,U}{8,16,32,64}` APIs in the `std::sync::atomic` and `core::sync::atomic` modules. Proposed in #56753 and tracked in #32976 this feature has been unstable for quite some time and is hopefully ready to go over the finish line now! The API is being stabilized as-is. The API of `AtomicU8` and friends mirrors that of `AtomicUsize`. A list of changes made here are: * A portability documentation section has been added to describe the current state of affairs. * Emulation of smaller-size atomics with larger-size atomics has been documented. * As an added bonus, `ATOMIC_*_INIT` is now scheduled for deprecation across the board in 1.34.0 now that `const` functions can be invoked in statics. Note that the 128-bit atomic types are omitted from this stabilization explicitly. They have far less platform support than the other atomic types, and will likely require further discussion about their best location. Closes #32976 Closes #56753

bors · 2019-01-26T12:20:55Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: sfackler
Pushing f95834b to master...

…tegers, r=dtolnay Destabilize fixed-width const defined atomic integers With this PR version 1.34.0 onwards const declarations of atomic integers will be unstable. * Closes #58089 * Reverts partially: #57425

The deprecations will be fixed later by raising the minimum supported Rust version for this crate. These deprecations take effect in Rust 1.34 and were enabled in rust-lang/rust#57425.

Pkgsrc changes: * Bump required rust version to build to 1.33.0. * Adapt patches to changed file locations. * (I worry about 32-bit ports, now that Atomic64 apparently is First-Class; this has been built on NetBSD/amd64 so far) Upstream changes: Version 1.34.0 (2019-04-11) ========================== Language -------- - [You can now use `#[deprecated = "reason"]`][58166] as a shorthand for `#[deprecated(note = "reason")]`. This was previously allowed by mistake but had no effect. - [You can now accept token streams in `#[attr()]`,`#[attr[]]`, and `#[attr{}]` procedural macros.][57367] - [You can now write `extern crate self as foo;`][57407] to import your crate's root into the extern prelude. Compiler -------- - [You can now target `riscv64imac-unknown-none-elf` and `riscv64gc-unknown-none-elf`.][58406] - [You can now enable linker plugin LTO optimisations with `-C linker-plugin-lto`.][58057] This allows rustc to compile your Rust code into LLVM bitcode allowing LLVM to perform LTO optimisations across C/C++ FFI boundaries. - [You can now target `powerpc64-unknown-freebsd`.][57809] Libraries --------- - [The trait bounds have been removed on some of `HashMap<K, V, S>`'s and `HashSet<T, S>`'s basic methods.][58370] Most notably you no longer require the `Hash` trait to create an iterator. - [The `Ord` trait bounds have been removed on some of `BinaryHeap<T>`'s basic methods.][58421] Most notably you no longer require the `Ord` trait to create an iterator. - [The methods `overflowing_neg` and `wrapping_neg` are now `const` functions for all numeric types.][58044] - [Indexing a `str` is now generic over all types that implement `SliceIndex<str>`.][57604] - [`str::trim`, `str::trim_matches`, `str::trim_{start, end}`, and `str::trim_{start, end}_matches` are now `#[must_use]`][57106] and will produce a warning if their returning type is unused. - [The methods `checked_pow`, `saturating_pow`, `wrapping_pow`, and `overflowing_pow` are now available for all numeric types.][57873] These are equivalvent to methods such as `wrapping_add` for the `pow` operation. Stabilized APIs --------------- #### std & core * [`Any::type_id`] * [`Error::type_id`] * [`atomic::AtomicI16`] * [`atomic::AtomicI32`] * [`atomic::AtomicI64`] * [`atomic::AtomicI8`] * [`atomic::AtomicU16`] * [`atomic::AtomicU32`] * [`atomic::AtomicU64`] * [`atomic::AtomicU8`] * [`convert::Infallible`] * [`convert::TryFrom`] * [`convert::TryInto`] * [`iter::from_fn`] * [`iter::successors`] * [`num::NonZeroI128`] * [`num::NonZeroI16`] * [`num::NonZeroI32`] * [`num::NonZeroI64`] * [`num::NonZeroI8`] * [`num::NonZeroIsize`] * [`slice::sort_by_cached_key`] * [`str::escape_debug`] * [`str::escape_default`] * [`str::escape_unicode`] * [`str::split_ascii_whitespace`] #### std * [`Instant::checked_add`] * [`Instant::checked_sub`] * [`SystemTime::checked_add`] * [`SystemTime::checked_sub`] Cargo ----- - [You can now use alternative registries to crates.io.][cargo/6654] Misc ---- - [You can now use the `?` operator in your documentation tests without manually adding `fn main() -> Result<(), _> {}`.][56470] Compatibility Notes ------------------- - [`Command::before_exec` is now deprecated in favor of the unsafe method `Command::pre_exec`.][58059] - [Use of `ATOMIC_{BOOL, ISIZE, USIZE}_INIT` is now deprecated.][57425] As you can now use `const` functions in `static` variables. [58370]: rust-lang/rust#58370 [58406]: rust-lang/rust#58406 [58421]: rust-lang/rust#58421 [58166]: rust-lang/rust#58166 [58044]: rust-lang/rust#58044 [58057]: rust-lang/rust#58057 [58059]: rust-lang/rust#58059 [57809]: rust-lang/rust#57809 [57873]: rust-lang/rust#57873 [57604]: rust-lang/rust#57604 [57367]: rust-lang/rust#57367 [57407]: rust-lang/rust#57407 [57425]: rust-lang/rust#57425 [57106]: rust-lang/rust#57106 [56470]: rust-lang/rust#56470 [cargo/6654]: rust-lang/cargo#6654 [`Any::type_id`]: https://doc.rust-lang.org/std/any/trait.Any.html#tymethod.type_id [`Error::type_id`]: https://doc.rust-lang.org/std/error/trait.Error.html#tymethod.type_id [`atomic::AtomicI16`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI16.html [`atomic::AtomicI32`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI32.html [`atomic::AtomicI64`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI64.html [`atomic::AtomicI8`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI8.html [`atomic::AtomicU16`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU16.html [`atomic::AtomicU32`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU32.html [`atomic::AtomicU64`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU64.html [`atomic::AtomicU8`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU8.html [`convert::Infallible`]: https://doc.rust-lang.org/std/convert/enum.Infallible.html [`convert::TryFrom`]: https://doc.rust-lang.org/std/convert/trait.TryFrom.html [`convert::TryInto`]: https://doc.rust-lang.org/std/convert/trait.TryInto.html [`iter::from_fn`]: https://doc.rust-lang.org/std/iter/fn.from_fn.html [`iter::successors`]: https://doc.rust-lang.org/std/iter/fn.successors.html [`num::NonZeroI128`]: https://doc.rust-lang.org/std/num/struct.NonZeroI128.html [`num::NonZeroI16`]: https://doc.rust-lang.org/std/num/struct.NonZeroI16.html [`num::NonZeroI32`]: https://doc.rust-lang.org/std/num/struct.NonZeroI32.html [`num::NonZeroI64`]: https://doc.rust-lang.org/std/num/struct.NonZeroI64.html [`num::NonZeroI8`]: https://doc.rust-lang.org/std/num/struct.NonZeroI8.html [`num::NonZeroIsize`]: https://doc.rust-lang.org/std/num/struct.NonZeroIsize.html [`slice::sort_by_cached_key`]: https://doc.rust-lang.org/std/slice/fn.sort_by_cached_key [`str::escape_debug`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_debug [`str::escape_default`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_default [`str::escape_unicode`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_unicode [`str::split_ascii_whitespace`]: https://doc.rust-lang.org/std/primitive.str.html#method.split_ascii_whitespace [`Instant::checked_add`]: https://doc.rust-lang.org/std/time/struct.Instant.html#method.checked_add [`Instant::checked_sub`]: https://doc.rust-lang.org/std/time/struct.Instant.html#method.checked_sub [`SystemTime::checked_add`]: https://doc.rust-lang.org/std/time/struct.SystemTime.html#method.checked_add [`SystemTime::checked_sub`]: https://doc.rust-lang.org/std/time/struct.SystemTime.html#method.checked_sub

rust-highfive assigned joshtriplett Jan 7, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2019

alexcrichton mentioned this pull request Jan 7, 2019

Stabilize the integer_atomics feature: Atomic{I,U}{8,16,32,64} #56753

Closed

3 tasks

Amanieu reviewed Jan 7, 2019

View reviewed changes

src/libcore/sync/atomic.rs Outdated Show resolved Hide resolved

alexcrichton force-pushed the stabilize-atomics branch from 9ec879f to 626a6a8 Compare January 8, 2019 03:47

rust-highfive assigned sfackler and unassigned joshtriplett Jan 8, 2019

rust-lang deleted a comment from rust-highfive Jan 9, 2019

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 9, 2019

Centril reviewed Jan 9, 2019

View reviewed changes

src/libcore/sync/atomic.rs Outdated Show resolved Hide resolved

Centril added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jan 10, 2019

alexcrichton force-pushed the stabilize-atomics branch from 626a6a8 to 14b36fb Compare January 25, 2019 19:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2019

Centril mentioned this pull request Jan 26, 2019

Rollup of 10 pull requests #57911

Closed

Centril mentioned this pull request Jan 26, 2019

Rollup of 9 pull requests #57912

Closed

bors merged commit 14b36fb into rust-lang:master Jan 26, 2019

ollie27 mentioned this pull request Jan 27, 2019

rustdoc ignores deprecation markers on constants #57917

Closed

scottmcm mentioned this pull request Feb 3, 2019

Don't newly-stabilize already-deprecated ATOMIC_I64_INIT & friends in 1.34 #58089

Closed

appaquet mentioned this pull request Feb 13, 2019

Upstream capnp thread safe modification once we have AtomicU64 stable. appaquet/exocore#12

Closed

vertexclique mentioned this pull request Feb 21, 2019

Destabilize fixed-width const defined atomic integers #58616

Merged

Havvy mentioned this pull request Mar 3, 2019

Remove target_has_atomic. rust-lang/reference#529

Merged

alexcrichton deleted the stabilize-atomics branch March 12, 2019 20:27

lucab mentioned this pull request Mar 26, 2019

switch to AtomicU64/AtomicI64 when they stabilize, remove most "as usize" / "as u64" casts spacejam/sled#548

Closed

Centril added this to the 1.34 milestone Apr 26, 2019

tamird mentioned this pull request Jul 9, 2022

Tracking issue for integer_atomics (AtomicU128/AtomicI128) #99069

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

std: Stabilize fixed-width integer atomics #57425

std: Stabilize fixed-width integer atomics #57425

Uh oh!

alexcrichton commented Jan 7, 2019

Uh oh!

alexcrichton commented Jan 7, 2019

Uh oh!

Uh oh!

alexcrichton commented Jan 8, 2019

Uh oh!

Uh oh!

Centril commented Jan 25, 2019

Uh oh!

alexcrichton commented Jan 25, 2019

Uh oh!

bors commented Jan 25, 2019

Uh oh!

bors commented Jan 26, 2019

Uh oh!

bors commented Jan 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

std: Stabilize fixed-width integer atomics #57425

std: Stabilize fixed-width integer atomics #57425

Uh oh!

Conversation

alexcrichton commented Jan 7, 2019

Uh oh!

alexcrichton commented Jan 7, 2019

Uh oh!

Uh oh!

alexcrichton commented Jan 8, 2019

Uh oh!

Uh oh!

Centril commented Jan 25, 2019

Uh oh!

alexcrichton commented Jan 25, 2019

Uh oh!

bors commented Jan 25, 2019

Uh oh!

bors commented Jan 26, 2019

Uh oh!

bors commented Jan 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants