-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Change bounds on TryFrom
blanket impl to use Into
instead of From
#56796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f8bd80a
Change bounds on `TryFrom` blanket impl to use `Into` instead of `From`
RustyYato 7a25a7c
Changed expected error message for TryFrom
RustyYato a1be813
Fixed `Into` bound on `TryFrom` error.
RustyYato db9fe1c
added test to show motivation for modified TryFrom impl
RustyYato 7dd078f
fixed test, now it doesn't use a fundemental type
RustyYato ea68b3f
update to reflect changes recommended by @shepmaster his review
RustyYato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// This test relies on `TryFrom` being blanket impl for all `T: Into` | ||
// and `TryInto` being blanket impl for all `U: TryFrom` | ||
|
||
// This test was added to show the motivation for doing this | ||
// over `TryFrom` being blanket impl for all `T: From` | ||
|
||
#![feature(try_from, never_type)] | ||
|
||
use std::convert::TryInto; | ||
|
||
struct Foo<T> { | ||
t: T, | ||
} | ||
|
||
// This fails to compile due to coherence restrictions | ||
// as of Rust version 1.32.x, therefore it could not be used | ||
// instead of the `Into` version of the impl, and serves as | ||
// motivation for a blanket impl for all `T: Into`, instead | ||
// of a blanket impl for all `T: From` | ||
/* | ||
impl<T> From<Foo<T>> for Box<T> { | ||
fn from(foo: Foo<T>) -> Box<T> { | ||
Box::new(foo.t) | ||
} | ||
} | ||
*/ | ||
|
||
impl<T> Into<Vec<T>> for Foo<T> { | ||
fn into(self) -> Vec<T> { | ||
vec![self.t] | ||
} | ||
} | ||
|
||
pub fn main() { | ||
let _: Result<Vec<i32>, !> = Foo { t: 10 }.try_into(); | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.