-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Propagate all closure requirements to the caller #56486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 2 commits into
rust-lang:master
from
matthewjasper:propagate-all-closure-bounds
Dec 4, 2018
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
src/test/ui/nll/closure-requirements/propagate-multiple-requirements.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// Test that we propagate *all* requirements to the caller, not just the first | ||
// one. | ||
|
||
#![feature(nll)] | ||
|
||
fn once<S, T, U, F: FnOnce(S, T) -> U>(f: F, s: S, t: T) -> U { | ||
f(s, t) | ||
} | ||
|
||
pub fn dangle() -> &'static [i32] { | ||
let other_local_arr = [0, 2, 4]; | ||
let local_arr = other_local_arr; | ||
let mut out: &mut &'static [i32] = &mut (&[1] as _); | ||
once(|mut z: &[i32], mut out_val: &mut &[i32]| { | ||
// We unfortunately point to the first use in the closure in the error | ||
// message | ||
z = &local_arr; //~ ERROR | ||
*out_val = &local_arr; | ||
}, &[] as &[_], &mut *out); | ||
*out | ||
} | ||
|
||
fn main() { | ||
println!("{:?}", dangle()); | ||
} |
17 changes: 17 additions & 0 deletions
17
src/test/ui/nll/closure-requirements/propagate-multiple-requirements.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
error[E0597]: `local_arr` does not live long enough | ||
--> $DIR/propagate-multiple-requirements.rs:17:14 | ||
| | ||
LL | let mut out: &mut &'static [i32] = &mut (&[1] as _); | ||
| ------------------- type annotation requires that `local_arr` is borrowed for `'static` | ||
LL | once(|mut z: &[i32], mut out_val: &mut &[i32]| { | ||
| ----------------------------------------- value captured here | ||
... | ||
LL | z = &local_arr; //~ ERROR | ||
| ^^^^^^^^^ borrowed value does not live long enough | ||
... | ||
LL | } | ||
| - `local_arr` dropped here while still borrowed | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0597`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.