Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a keyword in raw identifier example #55224

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Use a keyword in raw identifier example #55224

merged 1 commit into from
Oct 22, 2018

Conversation

kryptan
Copy link
Contributor

@kryptan kryptan commented Oct 20, 2018

That's a very small documentation fix. The text says "you can now use keywords as identifiers" but example didn't use a keyword and would work without raw identifiers.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2018
@matthewjasper matthewjasper added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 21, 2018
@matthewjasper
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 21, 2018

📌 Commit e10f0cd has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2018
@pietroalbini pietroalbini added T-release Relevant to the release subteam, which will review and decide on the PR/issue. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Oct 21, 2018
@pietroalbini
Copy link
Member

Accepting the backport of a release notes fix.

bors added a commit that referenced this pull request Oct 22, 2018
@bors
Auto merge of #55224 - kryptan:master, r=matthewjasper
a66dc8a 
Use a keyword in raw identifier example

That's a very small documentation fix. The text says "you can now use keywords as identifiers" but example didn't use a keyword and would work without raw identifiers.
@bors
Copy link
Contributor

bors commented Oct 22, 2018

⌛ Testing commit e10f0cd with merge a66dc8a...

@bors
Copy link
Contributor

bors commented Oct 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matthewjasper
Pushing a66dc8a to master...

@bors bors merged commit e10f0cd into rust-lang:master Oct 22, 2018
@pietroalbini pietroalbini mentioned this pull request Oct 23, 2018
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 23, 2018
bors added a commit that referenced this pull request Oct 23, 2018
@bors
Auto merge of #55289 - pietroalbini:beta-backports, r=pietroalbini
c977fb2 
[beta] Rollup backports

Merged and approved:

* #55231: pick a reference issue for absolute-paths future incompatibility info
* #55224: Use a keyword in raw identifier example

r? @ghost
bors added a commit that referenced this pull request Oct 23, 2018
@bors
Auto merge of #55289 - pietroalbini:beta-backports, r=pietroalbini
f33946f 
[beta] Rollup backports

Merged and approved:

* #55231: pick a reference issue for absolute-paths future incompatibility info
* #55224: Use a keyword in raw identifier example

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kryptan @rust-highfive @matthewjasper @bors @pietroalbini @aturon