Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLL performance boost #51399

Merged
merged 1 commit into from
Jun 8, 2018
Merged

NLL performance boost #51399

merged 1 commit into from
Jun 8, 2018

Conversation

ngg
Copy link
Contributor

@ngg ngg commented Jun 6, 2018 •
edited by ishitatsuyuki
Loading

This makes compilation of the inflate benchmark compile 2 times faster on my computer when NLL is enabled.
This does not fix the #51377 perfectly, it's still 4-5 times slower than without NLL, but it's a start.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2018
@Mark-Simulacrum
Copy link
Member

r? @nikomatsakis

Seems like a trivial change...

nikomatsakis
nikomatsakis approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍭 nice catch!

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 6, 2018

📌 Commit f1c9247 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2018
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 6, 2018
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 6, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51399 - ngg:nll-performance, r=nikomatsakis
ff120c9 
NLL performance boost

This makes compilation of the [inflate](https://github.com/rust-lang-nursery/rustc-perf/tree/master/collector/benchmarks/inflate) benchmark compile 2 times faster on my computer when NLL is enabled.
This does not fix rust-lang#51377 perfectly, it's still 4-5 times slower than without NLL, but it's a start.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 7, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51399 - ngg:nll-performance, r=nikomatsakis
9d78241 
NLL performance boost

This makes compilation of the [inflate](https://github.com/rust-lang-nursery/rustc-perf/tree/master/collector/benchmarks/inflate) benchmark compile 2 times faster on my computer when NLL is enabled.
This does not fix rust-lang#51377 perfectly, it's still 4-5 times slower than without NLL, but it's a start.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 7, 2018
Closed
@ishitatsuyuki
Copy link
Contributor

ishitatsuyuki commented Jun 7, 2018 •
edited
Loading

I've edited the description to not close #51377. cc @Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 7, 2018

⌛ Testing commit f1c9247 with merge e745cf1...

bors added a commit that referenced this pull request Jun 7, 2018
@bors
Auto merge of #51399 - ngg:nll-performance, r=nikomatsakis
e745cf1 
NLL performance boost

This makes compilation of the [inflate](https://github.com/rust-lang-nursery/rustc-perf/tree/master/collector/benchmarks/inflate) benchmark compile 2 times faster on my computer when NLL is enabled.
This does not fix the #51377 perfectly, it's still 4-5 times slower than without NLL, but it's a start.
@bors
Copy link
Contributor

bors commented Jun 7, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2018
@rust-highfive
Copy link
Collaborator

The job dist-i686-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
uploading "e745cf17cdfc02f86c2ce268ecac129e7f3b3e63/rust-analysis-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "e745cf17cdfc02f86c2ce268ecac129e7f3b3e63/rustc-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "e745cf17cdfc02f86c2ce268ecac129e7f3b3e63/cargo-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "e745cf17cdfc02f86c2ce268ecac129e7f3b3e63/rust-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
/home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:81:in `abort_upload': multipart upload failed: execution expired (Aws::S3::MultipartUploadError)
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:70:in `upload_parts'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:44:in `upload'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/file_uploader.rb:32:in `upload'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/object.rb:252:in `upload_file'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-s3-1.9.7/lib/dpl/provider/s3.rb:99:in `block (2 levels) in upload_multithreaded'
failed to deploy

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Collaborator

The job dist-i686-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
uploading "e745cf17cdfc02f86c2ce268ecac129e7f3b3e63/rust-analysis-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "e745cf17cdfc02f86c2ce268ecac129e7f3b3e63/rustc-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "e745cf17cdfc02f86c2ce268ecac129e7f3b3e63/cargo-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "e745cf17cdfc02f86c2ce268ecac129e7f3b3e63/rust-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
/home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:81:in `abort_upload': multipart upload failed: execution expired (Aws::S3::MultipartUploadError)
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:70:in `upload_parts'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:44:in `upload'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/file_uploader.rb:32:in `upload'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.63/lib/aws-sdk-resources/services/s3/object.rb:252:in `upload_file'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-s3-1.9.7/lib/dpl/provider/s3.rb:99:in `block (2 levels) in upload_multithreaded'
failed to deploy

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum
Copy link
Member

@bors retry - network error

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2018
@pietroalbini pietroalbini mentioned this pull request Jun 7, 2018
Open
kennytm added a commit to kennytm/rust that referenced this pull request Jun 7, 2018
@kennytm
Rollup merge of rust-lang#51399 - ngg:nll-performance, r=nikomatsakis
326331c 
NLL performance boost

This makes compilation of the [inflate](https://github.com/rust-lang-nursery/rustc-perf/tree/master/collector/benchmarks/inflate) benchmark compile 2 times faster on my computer when NLL is enabled.
This does not fix the rust-lang#51377 perfectly, it's still 4-5 times slower than without NLL, but it's a start.
@kennytm kennytm mentioned this pull request Jun 7, 2018
Merged
bors added a commit that referenced this pull request Jun 7, 2018
@bors
Auto merge of #51426 - kennytm:rollup, r=kennytm
1b4c921 
Rollup of 9 pull requests

Successful merges:

 - #51186 (Remove two redundant .nll.stderr files)
 - #51283 (Deny #[cfg] and #[cfg_attr] on generic parameters.)
 - #51368 (Fix the use of closures within #[panic_implementation])
 - #51380 (Remove dependency on fmt_macros from typeck)
 - #51389 (rustdoc: Fix missing stability and src links for inlined external macros)
 - #51399 (NLL performance boost)
 - #51407 (Update RLS and Rustfmt)
 - #51417 (Revert #49719)
 - #51420 (Tries to address the recent network issues)

Failed merges:
@bors bors merged commit f1c9247 into rust-lang:master Jun 8, 2018
@leonardo-m
Copy link

leonardo-m commented Jun 9, 2018 •
edited
Loading

With the last two improvements to NLL, on my code rustc (with --emit=metadata) is now less than 2X slower compared to not-NLL (originally it was 9X slower).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ngg @rust-highfive @Mark-Simulacrum @nikomatsakis @bors @ishitatsuyuki @leonardo-m @petrochenkov