Add rustdoc to x.py check #50062
Merged
Add rustdoc to x.py check #50062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #49890) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
This can often encounter errors after modifying rustc, so it's useful to include it in the steps that are checked.
varkor
force-pushed
the
xpy-check-rustdoc
branch
from
ce7bbe3 to
adc9c8c
Compare
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
xpy-check-rustdoc
branch
from
adc9c8c to
261da71
Compare
varkor
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 261da71 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 20, 2018
Add rustdoc to x.py check Modifying rustc can often cause errors in rustdoc, so it's useful to include it in the steps that are checked. One thing that I was unsure about was when to call `clear_if_dirty` (both in this step, and in other steps in relation to this one) — we want to be sure rustdoc will always be rechecked after modifying previous steps — but does this belong in rustdoc, or the other steps? Fixes #49917. r? @Mark-Simulacrum
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Apr 20, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying rustc can often cause errors in rustdoc, so it's useful to include it in the steps that are checked.
One thing that I was unsure about was when to call
clear_if_dirty(both in this step, and in other steps in relation to this one) — we want to be sure rustdoc will always be rechecked after modifying previous steps — but does this belong in rustdoc, or the other steps?Fixes #49917.
r? @Mark-Simulacrum