rustbuild: Pass -j1 to OpenSSL make install
#48901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We explicitly do this when compiling OpenSSL itself due to weird racy issues in its build system, and now we've started seeing issues in the `make install` step so let's try and see what ratcheting down the parallelism does here...
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Seems viable if unfortunate. @bors r+ p=5 (hopefully fixes spurious failure) |
|
📌 Commit 3043723 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 10, 2018
rustbuild: Pass `-j1` to OpenSSL `make install` We explicitly do this when compiling OpenSSL itself due to weird racy issues in its build system, and now we've started seeing issues in the `make install` step so let's try and see what ratcheting down the parallelism does here...
|
OpenSSL 1.1.0's build system is parallel-safe, but 1.0.x's definitely isn't. |
|
☀️ Test successful - status-appveyor, status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We explicitly do this when compiling OpenSSL itself due to weird racy issues in
its build system, and now we've started seeing issues in the
make installstepso let's try and see what ratcheting down the parallelism does here...