Remove the IGNORED_ATTR_NAMES thread local#47635
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 23, 2018
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-waiting-on-review
Member
|
Can you provide some reasoning why you want to change this? |
Contributor
Author
|
It's part of the parallelization work. Global state should be avoided in general too. |
Member
|
@bors r+ rollup OK, but in general I would prefer if we waited with refactorings like these until we have decided how to actually approach parallelization. |
Collaborator
|
📌 Commit 643e71e has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 23, 2018
Remove the IGNORED_ATTR_NAMES thread local
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.