Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make non_snake_case lint allow extern no-mangle functions #44966

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

zackmdavis
Copy link
Member

Resolves #31924.

r? @sfackler

@sfackler sfackler added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Oct 2, 2017
@sfackler
Copy link
Member

sfackler commented Oct 2, 2017

r? @aturon

I am obviously in favor of this 😄 but the lang team is the one to decide here.

@rust-highfive rust-highfive assigned aturon and unassigned sfackler Oct 2, 2017
@aturon
Copy link
Member

aturon commented Oct 2, 2017

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Oct 2, 2017

📌 Commit b989101 has been approved by aturon

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 2, 2017
@bors
Copy link
Contributor

bors commented Oct 3, 2017

⌛ Testing commit b989101 with merge 67ed489...

bors added a commit that referenced this pull request Oct 3, 2017
make non_snake_case lint allow extern no-mangle functions

Resolves #31924.

r? @sfackler
@bors
Copy link
Contributor

bors commented Oct 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 67ed489 to master...

@bors bors merged commit b989101 into rust-lang:master Oct 3, 2017
@zackmdavis zackmdavis deleted the no_mangle_no_snake branch January 13, 2018 07:46
bors added a commit to rust-lang/rust-analyzer that referenced this pull request Sep 18, 2024
Don't lint names of #[no_mangle] extern fns

[Rust doesn't run the `non_snake_case_name` lint on `extern fn`s with the `#[no_mangle]` attribute](rust-lang/rust#44966).

The conditions are:
- The function must be `extern` and have a `#[no_mangle]` attribute.
- The function's ABI must not be explicitly set to "Rust".

This PR replicates that logic here.
lnicola pushed a commit to lnicola/rust that referenced this pull request Sep 25, 2024
Don't lint names of #[no_mangle] extern fns

[Rust doesn't run the `non_snake_case_name` lint on `extern fn`s with the `#[no_mangle]` attribute](rust-lang#44966).

The conditions are:
- The function must be `extern` and have a `#[no_mangle]` attribute.
- The function's ABI must not be explicitly set to "Rust".

This PR replicates that logic here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants