Rollup of 7 pull requests #41977
Closed
Rollup of 7 pull requests #41977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Mark-Simulacrum
commented
May 13, 2017
Mark-Simulacrum
commented
- Successful merges: Add markdown-[before|after]-content options #41826, Include the crate's root module in save-analysis #41919, rustc_resolve: don't deny outer type parameters in embedded constants. #41939, Disallow ._ in float literal. #41946, Fix anchor invalid redirection to search #41950, Update RLS to solve serious crash #41969, Pass static crt to llvm cmake configuration #41975
- Failed merges:
…, r=frewsxcv Add markdown-[before|after]-content options cc @nical r? @rust-lang/docs
Include the crate's root module in save-analysis r? @eddyb
…petrochenkov rustc_resolve: don't deny outer type parameters in embedded constants. This solves a problem noted at rust-lang#29646 (comment), where an associated const default in a trait couldn't refer to `Self` or type parameters, due to inaccuracies in lexical scoping. I've also allowed "embedded expressions" (`[T; expr]`, `[x; expr]`, `typeof expr`) to refer to type parameters in scope. *However*, the typesystem still doesn't handle rust-lang#34344. Fully resolving that issue requires breaking cycles more aggressively (e.g. lazy evaluation), *even* in when the expression doesn't depend on type parameters, to type-check it at all, and then also type-level "constant projections" (in the vein of `{expr}` from const generics).
…loat, r=petrochenkov Disallow ._ in float literal. This patch makes lexer stop parsing number literals before `._`, as well as before `.a`. Underscore itself is still allowed like in `4_000_000.000_000_`. Fixes a half part of rust-lang#41723. The other is `""_`.
…wsxcv Fix anchor invalid redirection to search Fixes rust-lang#41933. r? @rust-lang/docs
Update RLS to solve serious crash As a follow-up to rust-lang/rls#312, this PR contains the fix to the latest experienced RLS crashes, which should hopefully reach the nightly release as soon as possible.
…-cmake-config, r=alexcrichton Pass static crt to llvm cmake configuration Solves rust-lang#40246
|
Some changes occurred in HTML/CSS. |
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit f9dc605 has been approved by |
|
⌛ Testing commit f9dc605 with merge bc9bd97... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.