Closed
Conversation
Contributor
frewsxcv
commented
Apr 21, 2017
frewsxcv
commented
- Successful merges: Support dynamically-linked and/or native musl targets #40113, Add test for issue 33884 #41435, Remove items that are unstable and deprecated #41437, Update cargo for 1.18.0. #41450
- Failed merges:
This controls the value of the crt-static feature used when building the compiler and standard library. It can be set per target.
This avoids the possibility of a duplicate or conflicting crt-static command line option sent to rustc.
These options only exist for the special case of static cross-linking pure rust code for a musl-based target with a non-musl toolchain. In all other situations (dynamic linking, presence of a native or cross compiler) these objects will be automatically provided and linked by the toolchain.
To maintain existing behavior, it is disabled by default on all architectures except MIPS.
These were conditioned on architecture because traditionally MIPS was dynamically linked, while other arches used musl for static linking. Now that we support both methods of linking on all architectures, these special cases no longer make sense Add a comment explaining why copying startup files is always necessary
[unstable, deprecated since 1.16.0]
[unstable, deprecated since 1.13.0]
[unstable, deprecated since 1.12.0]
[unstable, deprecated since 1.15.0]
[unstable, deprecated since 1.15.0]
[unstable, deprecated since 1.12.0]
[unstable, deprecated since 1.15.0]
[unstable, deprecated since 1.11.0]
[unstable, deprecated since 1.11.0]
Bump our associated cargo to pick up the RUSTC_WRAPPER feature for use with build caches.
Support dynamically-linked and/or native musl targets These changes allow native compilation on musl-based distributions and the use of dynamic libraries on linux-musl targets. This is intended to remove limitations based on past assumptions about musl targets, while maintaining existing behavior by default. A minor related bugfix is included.
Add test for issue 33884 Fix rust-lang#33884. r=nikomatsakis
… r=alexcrichton
Remove items that are unstable and deprecated
This removes unstable items that have been deprecated for more than one cycle.
- Since 1.16.0, `#![feature(enumset)]`
- All of `mod collections::enum_set`
- Since 1.15.0, `#![feature(borrow_state)]`
- `cell::BorrowState`
- `RefCell::borrow_state()`
- Since 1.15.0, `#![feature(is_unique)]`
- `Rc::is_unique()` (made private like `Arc::is_unique()`)
- Since 1.15.0, `#![feature(rc_would_unwrap)]`
- `Rc::would_wrap()`
- Since 1.13.0, `#![feature(binary_heap_extras)]`
- `BinaryHeap::push_pop()`
- `BinaryHeap::replace()`
- Since 1.12.0, `#![feature(as_unsafe_cell)]`
- `Cell::as_unsafe_cell()`
- `RefCell::as_unsafe_cell()`
- Since 1.12.0, `#![feature(map_entry_recover_keys)]`
- `btree_map::OccupiedEntry::remove_pair()`
- `hash_map::OccupiedEntry::remove_pair()`
- Since 1.11.0, `#![feature(float_extras)]`
- `Float::nan()`
- `Float::infinity()`
- `Float::neg_infinity()`
- `Float::neg_zero()`
- `Float::zero()`
- `Float::one()`
- `Float::integer_decode()`
- `f32::integer_decode()`
- `f32::ldexp()`
- `f32::frexp()`
- `f32::next_after()`
- `f64::integer_decode()`
- `f64::ldexp()`
- `f64::frexp()`
- `f64::next_after()`
- Since 1.11.0, `#![feature(zero_one)]`
- `num::Zero`
- `num::One`
Update cargo for 1.18.0. Bump our associated cargo to pick up the RUSTC_WRAPPER feature for use with build caches.
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Contributor
Author
|
@bors r+ p=10 |
Collaborator
|
📌 Commit 8876278 has been approved by |
Collaborator
|
⌛ Testing commit 8876278 with merge 43ec77e... |
Collaborator
|
💔 Test failed - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.