Fix formatting in the docs for std::process::Command::envs() #40794
Conversation
An empty line between the "Basic usage:" text and the example is required to properly format the code. Without the empty line, the example is not formatted as code.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
The travis failure looks like it may not be spurious? |
…and::envs(). The person who originally wrote the example forgot to include this attribute. This caused Travis CI to fail on commit 9b0a4a4 (rust-lang#40794), which just fixed formatting in the description of std::process::Command::envs().
|
@alexcrichton .... uh oh. Good thing standard style is to put these lines in, and now that we've switched to CommonMark, the old way won't be rendered properly, so this should shake out? But yeah that's not good. |
|
r=me if travis passes thanks @s3rvac ! |
|
@bors: r=steveklabnik |
|
📌 Commit 432673a has been approved by |
|
@alexcrichton Looks like that the person who originally wrote the example forgot to include the |
|
This time it looks like a spurious fail that has nothing to do with the PR: |
…vs-docs, r=steveklabnik Fix formatting in the docs for std::process::Command::envs() An empty line between the *Basic usage:* text and the example is required to properly format the code. Without the empty line, the example is not formatted as code. [Here](https://doc.rust-lang.org/std/process/struct.Command.html#method.envs) you can see the current (improper) formatting.
An empty line between the Basic usage: text and the example is required to properly format the code. Without the empty line, the example is not formatted as code.
Here you can see the current (improper) formatting.