Skip to content

rustc: Implement "deriving" for monomorphic structs via a syntax extensi... #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

pcwalton
Copy link
Contributor

...on

r? @brson

@brson
Copy link
Contributor

brson commented Nov 20, 2012

r+

@brson
Copy link
Contributor

brson commented Nov 20, 2012

There's a module of builder functions in ext::build that are partially redundant with some here, and some of the ones you've written deserve to be in build.

Things that exist in build:

  • plain_path is similar to mk_raw_path
  • create_expr -> mk_expr
  • plain_expr_path -> mk_path

Things that could go in build:

  • plain_pattern, plain_expr_lit_bool, plain_block

@brson
Copy link
Contributor

brson commented Nov 20, 2012

r+

@brson
Copy link
Contributor

brson commented Nov 20, 2012

This is very well commented

@brson
Copy link
Contributor

brson commented Nov 20, 2012

I actually can't picture the code generated by expand_deriving_enum_method after reading it quite a bit. A comment illustrating the pattern being implemented would help.

@pcwalton
Copy link
Contributor Author

r? @brson

@brson
Copy link
Contributor

brson commented Nov 21, 2012

r+

@brson
Copy link
Contributor

brson commented Nov 21, 2012

r+

@pcwalton pcwalton closed this Nov 21, 2012
RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants