Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for inclusive_range_syntax in compile-fail test suite #40031

Merged
merged 1 commit into from
Feb 25, 2017

Conversation

nikhilshagri
Copy link
Contributor

Fixes #39059
r? @est31

Forgot to leave a comment on the issue, hopefully nobody else is working on this one!

@durka
Copy link
Contributor

durka commented Feb 22, 2017

This is already tested at src/test/parse-fail/range_inclusive_gate.rs.

@est31
Copy link
Member

est31 commented Feb 22, 2017

@durka thanks for pointing this out! Seems I've missed that test when generating the list for #39059.

@cynicaldevil you should instead of adding the test add the // gate-test-... comment and add the test/parse-fail directory to the list of directories with feature gate tests inside so that its recognized.

@nikhilshagri
Copy link
Contributor Author

@est31 Updated PR.

@jseyfried
Copy link
Contributor

@bors delegate=est31

@bors
Copy link
Contributor

bors commented Feb 22, 2017

✌️ @est31 can now approve this pull request

@est31
Copy link
Member

est31 commented Feb 22, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Feb 22, 2017

📌 Commit b7b58ff has been approved by est31

@eddyb
Copy link
Member

eddyb commented Feb 25, 2017

@bors rollup

eddyb added a commit to eddyb/rust that referenced this pull request Feb 25, 2017
Added test for inclusive_range_syntax in compile-fail test suite

Fixes rust-lang#39059
r? @est31

Forgot to leave a comment on the issue, hopefully nobody else is working on this one!
eddyb added a commit to eddyb/rust that referenced this pull request Feb 25, 2017
Added test for inclusive_range_syntax in compile-fail test suite

Fixes rust-lang#39059
r? @est31

Forgot to leave a comment on the issue, hopefully nobody else is working on this one!
bors added a commit that referenced this pull request Feb 25, 2017
@bors bors merged commit b7b58ff into rust-lang:master Feb 25, 2017
@est31
Copy link
Member

est31 commented Feb 25, 2017

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants