Fix pre-cfg_attr notation in comment #38760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit aa3b126 has changed notation in the test from `#[ignore(cfg(ignorecfg))]` to `#[cfg_attr(ignorecfg, ignore)]`, but missed to change the comment in the accompanying Makefile.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Should be obvious when you inspect the changes of that directory via |
|
@bors r+ rollup |
|
📌 Commit 2dc2284 has been approved by |
|
⌛ Testing commit 2dc2284 with merge 4150ddf... |
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jan 2, 2017
Fix pre-cfg_attr notation in comment Commit aa3b126 has changed notation in the test from `#[ignore(cfg(ignorecfg))]` to `#[cfg_attr(ignorecfg, ignore)]`, but missed to change the comment in the accompanying Makefile.
|
💔 Test failed - status-travis |
|
@bors: retry
* network problem
…On Mon, Jan 2, 2017 at 2:20 AM bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/188204885>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38760 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95Jr5QIBhJXfRKvAjSjqTMArllv1Kks5rOM9KgaJpZM4LYwxt>
.
|
bors
added a commit
that referenced
this pull request
Jan 2, 2017
Fix pre-cfg_attr notation in comment Commit aa3b126 has changed notation in the test from `#[ignore(cfg(ignorecfg))]` to `#[cfg_attr(ignorecfg, ignore)]`, but missed to change the comment in the accompanying Makefile.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit aa3b126 has changed notation
in the test from
#[ignore(cfg(ignorecfg))]to#[cfg_attr(ignorecfg, ignore)],but missed to change the comment in the accompanying Makefile.