Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes magenta build warning. #38521

Merged
merged 1 commit into from
Dec 25, 2016
Merged

Removes magenta build warning. #38521

merged 1 commit into from
Dec 25, 2016

Conversation

jxson
Copy link
Contributor

@jxson jxson commented Dec 21, 2016

Small bug fix to remove an unused type in the magenta process code that causes build failures for magenta's rustc.

r? @alexcrichton

@tedsta @raphlinus

@jxson
Removes magenta build warning.
88af5bf 
Small bug fix to remove an unused type in the magenta process code that causes build failures for magenta's rustc.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@raphlinus
Copy link
Contributor

Looks good to me. Looking forward to the day when a patch like this will cause a CI bot to go from red to green :)

@sfackler
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 22, 2016

📌 Commit 88af5bf has been approved by sfackler

@bors
Copy link
Contributor

bors commented Dec 22, 2016

⌛ Testing commit 88af5bf with merge 6d9fe2c...

@bors
Copy link
Contributor

bors commented Dec 22, 2016

💔 Test failed - auto-mac-32-opt

@sanxiyn
Copy link
Member

sanxiyn commented Dec 22, 2016

@bors retry

@bors
Copy link
Contributor

bors commented Dec 22, 2016

⌛ Testing commit 88af5bf with merge ff234dc...

@bors
Copy link
Contributor

bors commented Dec 22, 2016

💔 Test failed - auto-mac-32-opt

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 24, 2016
@steveklabnik
Rollup merge of rust-lang#38521 - jxson:remove-magenta-warnings, r=sf…
e9a2a77 
…ackler

Removes magenta build warning.

Small bug fix to remove an unused type in the magenta process code that causes build failures for magenta's rustc.

r? @alexcrichton

@tedsta @raphlinus
@steveklabnik steveklabnik mentioned this pull request Dec 24, 2016
Merged
bors added a commit that referenced this pull request Dec 24, 2016
@bors
Auto merge of #38594 - steveklabnik:rollup, r=steveklabnik
e60aa62 
Rollup of 14 pull requests

- Successful merges: #37956, #38013, #38297, #38480, #38497, #38502, #38505, #38513, #38521, #38549, #38554, #38557, #38568, #38572
- Failed merges:
@bors bors merged commit 88af5bf into rust-lang:master Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jxson @rust-highfive @raphlinus @sfackler @bors @sanxiyn @alexcrichton