Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite, improve documentation for core::hash::BuildHasherDefault. #38334

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Rewrite, improve documentation for core::hash::BuildHasherDefault. #38334

merged 1 commit into from
Dec 19, 2016

Conversation

frewsxcv
Copy link
Member

Fixes #31242.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

r? @rust-lang/docs

cc @rust-lang/libs to make sure I'm using BuildHasherDefault correctly here.

@frewsxcv frewsxcv mentioned this pull request Dec 13, 2016
Closed
@steveklabnik
Copy link
Member

@bors: delegate=kmcallister

@bors
Copy link
Contributor

bors commented Dec 13, 2016

✌️ @kmcallister can now approve this pull request

@sfackler
Copy link
Member

LGTM

@GuillaumeGomez
Copy link
Member

You even added all urls. T_T What a great day!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Dec 13, 2016

📌 Commit ce1fbad has been approved by GuillaumeGomez

@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 15, 2016
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 15, 2016
@GuillaumeGomez
Rollup merge of rust-lang#38334 - frewsxcv:BuildHasherDefault, r=Guil…
24d2260 
…laumeGomez

Rewrite, improve documentation for `core::hash::BuildHasherDefault`.

Fixes rust-lang#31242.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 16, 2016
@GuillaumeGomez
Rollup merge of rust-lang#38334 - frewsxcv:BuildHasherDefault, r=Guil…
5f1f0e1 
…laumeGomez

Rewrite, improve documentation for `core::hash::BuildHasherDefault`.

Fixes rust-lang#31242.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 16, 2016
Closed
@bors
Copy link
Contributor

bors commented Dec 16, 2016

⌛ Testing commit ce1fbad with merge 652b82e...

@bors
Copy link
Contributor

bors commented Dec 16, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@frewsxcv
Copy link
Member Author

@bors retry

@bors
Copy link
Contributor

bors commented Dec 16, 2016

⌛ Testing commit ce1fbad with merge d10ae8d...

@bors
Copy link
Contributor

bors commented Dec 16, 2016

💔 Test failed - auto-mac-64-opt

@GuillaumeGomez
Copy link
Member

@bors: retry

@oyvindln
Copy link
Contributor

There is a failing doctest from this PR in the rollup #38407. Looks like there are some spelling issues.

@frewsxcv
Copy link
Member Author

@bors r-

@frewsxcv
Copy link
Member Author

@oyvindln Woops, thanks for letting me know! Spelling fixed in the latest force push.

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Dec 16, 2016

📌 Commit 17eac5d has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Dec 16, 2016

⌛ Testing commit 17eac5d with merge 953b687...

@bors
Copy link
Contributor

bors commented Dec 16, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton
Copy link
Member

alexcrichton commented Dec 16, 2016 via email

@frewsxcv
Copy link
Member Author

Travis found another typo.

@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Dec 16, 2016

📌 Commit d409fc3 has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 18, 2016
@GuillaumeGomez
Rollup merge of rust-lang#38334 - frewsxcv:BuildHasherDefault, r=Guil…
ca8f287 
…laumeGomez

Rewrite, improve documentation for `core::hash::BuildHasherDefault`.

Fixes rust-lang#31242.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 18, 2016
Closed
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Dec 19, 2016
@sanxiyn
Rollup merge of rust-lang#38334 - frewsxcv:BuildHasherDefault, r=Guil…
86cf922 
…laumeGomez

Rewrite, improve documentation for `core::hash::BuildHasherDefault`.

Fixes rust-lang#31242.
@sanxiyn sanxiyn mentioned this pull request Dec 19, 2016
Merged
bors added a commit that referenced this pull request Dec 19, 2016
@bors
Auto merge of #38466 - sanxiyn:rollup, r=sanxiyn
10271ea 
Rollup of 9 pull requests

- Successful merges: #38334, #38397, #38413, #38421, #38422, #38433, #38438, #38445, #38459
- Failed merges:
@bors bors merged commit d409fc3 into rust-lang:master Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@frewsxcv @rust-highfive @steveklabnik @bors @sfackler @GuillaumeGomez @oyvindln @alexcrichton @aturon