Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #38320

Closed
wants to merge 23 commits into from
Closed

Rollup of 8 pull requests #38320

wants to merge 23 commits into from

Conversation

GuillaumeGomez and others added 23 commits December 4, 2016 00:43
…4355).

In some versions of this font the ampersands are drawn badly.
Closes rust-lang#37915

This commit enhances documentation with several links and
fixes an error in the `sync_channel` documentation as well:
`send` doesn't panic when the senders are all disconnected
When an item is defined in an external macro it doesn't get a real
filename so we need to filter out these when generating src links for
reexported items.
…aumeGomez

Improve and fix mpsc documentation

Closes rust-lang#37915

This commit enhances documentation with several links and
fixes an error in the `sync_channel` documentation as well:
`send` doesn't panic when the senders are all disconnected

r? @steveklabnik
Avoid using locally installed Source Code Pro font (fixes rust-lang#24355).

In some versions of this font the ampersands are drawn badly.

A doc tree built with this change is at https://storage.googleapis.com/mbp-rust-builds/fonts/doc/std/index.html

I'm not seeing this problem locally so I'm not sure this fixes it, but based on the diagnosis in the bug it should.

I've made this a minimal change by only removing the one problematic font but maybe for consistency every font should be read from the Rust docs tree?
…omez

Improvements to `BTreeSet` documentation.

None
rustdoc: Remove broken src links from reexported items from macros

When an item is defined in an external macro it doesn't get a real
filename so we need to filter out these when generating src links for
reexported items.
Handle Ctrl+C in the build script
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Dec 12, 2016

📌 Commit 1a2e37c has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Dec 12, 2016

⌛ Testing commit 1a2e37c with merge 7bd37b1...

@bors
Copy link
Contributor

bors commented Dec 12, 2016

💔 Test failed - auto-win-msvc-64-opt

@frewsxcv frewsxcv closed this Dec 12, 2016
@frewsxcv frewsxcv deleted the rollup branch December 12, 2016 17:28
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.