Skip to content

Avoid loading and parsing unconfigured non-inline modules. #36482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2016
Merged

Avoid loading and parsing unconfigured non-inline modules. #36482

merged 2 commits into from
Sep 17, 2016

Conversation

jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Sep 14, 2016 •
edited
Loading

For example, #[cfg(any())] mod foo; will always compile after this PR, even if foo.rs and foo/mod.rs do not exist or do not contain valid Rust.

Fixes #36478 and fixes #27873.

r? @nrc

@jseyfried
Copy link
Contributor Author

cc @durka @retep998 @eddyb

@jseyfried jseyfried force-pushed the dont_load_unconfigured_noninline_modules branch from f18f0e3 to 6f0ee45 Compare September 15, 2016 08:17
@nrc
Copy link
Member

nrc commented Sep 16, 2016

@bors: r+

@bors
Copy link
Collaborator

bors commented Sep 16, 2016

📌 Commit 6f0ee45 has been approved by nrc

@sfackler sfackler added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 16, 2016
@bors
Copy link
Collaborator

bors commented Sep 17, 2016

⌛ Testing commit 6f0ee45 with merge 141012d...

bors added a commit that referenced this pull request Sep 17, 2016
@bors
Auto merge of #36482 - jseyfried:dont_load_unconfigured_noninline_mod…
141012d 
…ules, r=nrc

Avoid loading and parsing unconfigured non-inline modules.

For example, `#[cfg(any())] mod foo;` will always compile after this PR, even if `foo.rs` and `foo/mod.rs` do not exist or do not contain valid Rust.

Fixes #36478 and fixes #27873.

r? @nrc
@bors
Copy link
Collaborator

bors commented Sep 17, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 141012d to master...

@bors bors merged commit 6f0ee45 into rust-lang:master Sep 17, 2016
@jseyfried jseyfried deleted the dont_load_unconfigured_noninline_modules branch September 20, 2016 02:12
This was referenced Jan 17, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

relnotes Marks issues that should be documented in the release notes of the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Functions/modules using unstable *syntax* (e.g., impl Trait) can't be CFGed out on stable ABIs are validated before cfg-ing

4 participants

@jseyfried @nrc @bors @sfackler