Rollup of 11 pull requests #34470
Closed
Rollup of 11 pull requests #34470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"boostrap" instead of "bootstrap"
E0425: unresolved name
The macro gets used to create a mapping of identifiers to names and their associated functions. Since it creates a table of language items, let's rename it in a similar manner to how vec! creates a vec.
Improve diagnostics E0425: `use` (public) name E0425: unresolved name
Add example for `std::thread::sleep`. None
Parameters in doc comment should be formatted code-like. None
Fix typo in bootstrap README "boostrap" instead of "bootstrap"
Switched tense to clarify what is happening in the example
Fix typo in future incompatible lint Found in release triage.
Indicate how the `JoinHandle` struct is created. None
…ame, r=jseyfried Renames "lets_do_this" macro more appropriately. The macro gets used to create a mapping of identifiers to names and their associated functions. Since it creates a table of language items, let's rename it in a similar manner to how vec! creates a vec.
…illaumeGomez Add doc example for `std::thread::Builder::name`. None
Add hyperlinks to `std::fs` functions from `std::path`. None
…meGomez Indicate how the `std::path::Components` struct is created. None
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
@bors: r+ p=10 |
Collaborator
|
📌 Commit a4a4f1f has been approved by |
Collaborator
|
⌛ Testing commit a4a4f1f with merge 2c7c48a... |
Collaborator
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use(public) name #34379, Add example forstd::thread::sleep. #34406, Parameters in doc comment should be formatted code-like. #34410, Fix typo in bootstrap README #34411, Switched tense to clarify what is happening in the example #34414, Fix typo in future incompatible lint #34435, Indicate how theJoinHandlestruct is created. #34438, Renames "lets_do_this" macro more appropriately. #34445, Add doc example forstd::thread::Builder::name. #34465, Add hyperlinks tostd::fsfunctions fromstd::path. #34468, Indicate how thestd::path::Componentsstruct is created. #34469