Skip to content

Add regression test for #24424. #34453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Add regression test for #24424. #34453

merged 1 commit into from
Jun 27, 2016

Conversation

frewsxcv
Copy link
Member

Fixes #24424.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 913fbb5418d6526031d1d9f9066454cf42037769

@frewsxcv
Copy link
Member Author

What did I do incorrectly here?

thread 'main' panicked at 'Some tests failed
---- [compile-fail] compile-fail/issue-24424.rs stdout ----

error: /build/src/test/compile-fail/issue-24424.rs:14: unexpected "error": '14:1: 14:89: type annotations required: cannot resolve `T0: Trait0<'l0>` [E0283]'
error: /build/src/test/compile-fail/issue-24424.rs:14: expected error not found: type annotations required: cannot resolve `T0: main::Trait0<'l0>`
error: 1 unexpected errors found, 1 expected errors not found
status: exit code: 101
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /build/src/test/compile-fail/issue-24424.rs -L x86_64-unknown-linux-gnu/test/compile-fail/ --target=x86_64-unknown-linux-gnu --error-format json -Z unstable-options -L x86_64-unknown-linux-gnu/test/compile-fail/issue-24424.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o x86_64-unknown-linux-gnu/test/compile-fail/issue-24424.stage2-x86_64-unknown-linux-gnu --cfg rtopt -C rpath -O -L x86_64-unknown-linux-gnu/rt
actual errors (from JSON output): [
    Error {
        line_num: 14,
        kind: Some(
            Error
        ),
        msg: "14:1: 14:89: type annotations required: cannot resolve `T0: Trait0<\'l0>` [E0283]"
    },
    Error {
        line_num: 14,
        kind: Some(
            Note
        ),
        msg: "14:1: 14:89: required by `Trait0`"
    }
]
expected errors (from test file): [
    Error {
        line_num: 14,
        kind: Some(
            Error
        ),
        msg: "type annotations required: cannot resolve `T0: main::Trait0<\'l0>`"
    }
]

@alexcrichton
Copy link
Member

Looks like a note may need to be specified as well?

@frewsxcv frewsxcv force-pushed the regress branch 2 times, most recently from 2ac7d09 to 6fcac92 Compare June 25, 2016 00:24
@frewsxcv
Copy link
Member Author

Looks like the note was not the problem.

failures:
---- [compile-fail] compile-fail/issue-24424.rs stdout ----

error: /build/src/test/compile-fail/issue-24424.rs:14: unexpected "error": '14:1: 14:89: type annotations required: cannot resolve `T0: Trait0<'l0>` [E0283]'
error: /build/src/test/compile-fail/issue-24424.rs:14: expected error not found: type annotations required: cannot resolve `T0: main::Trait0<'l0>`
error: 1 unexpected errors found, 1 expected errors not found
status: exit code: 101
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /build/src/test/compile-fail/issue-24424.rs -L x86_64-unknown-linux-gnu/test/compile-fail/ --target=x86_64-unknown-linux-gnu --error-format json -Z unstable-options -L x86_64-unknown-linux-gnu/test/compile-fail/issue-24424.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o x86_64-unknown-linux-gnu/test/compile-fail/issue-24424.stage2-x86_64-unknown-linux-gnu --cfg rtopt -C rpath -O -L x86_64-unknown-linux-gnu/rt
actual errors (from JSON output): [
    Error {
        line_num: 14,
        kind: Some(
            Error
        ),
        msg: "14:1: 14:89: type annotations required: cannot resolve `T0: Trait0<\'l0>` [E0283]"
    },
    Error {
        line_num: 14,
        kind: Some(
            Note
        ),
        msg: "14:1: 14:89: required by `Trait0`"
    }
]
expected errors (from test file): [
    Error {
        line_num: 14,
        kind: Some(
            Error
        ),
        msg: "type annotations required: cannot resolve `T0: main::Trait0<\'l0>`"
    },
    Error {
        line_num: 14,
        kind: Some(
            Note
        ),
        msg: "required by `Trait0`"
    }
]
thread '[compile-fail] compile-fail/issue-24424.rs' panicked at 'explicit panic', /build/src/tools/compiletest/src/runtest.rs:1077
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    [compile-fail] compile-fail/issue-24424.rs
test result: FAILED. 2377 passed; 1 failed; 11 ignored; 0 measured

@dsprenkels
Copy link
Contributor

Diff. 😃

type annotations required: cannot resolve `T0: Trait0<\'l0>`
type annotations required: cannot resolve `T0: main::Trait0<\'l0>`
                                               ^~~~~~

@frewsxcv
Copy link
Member Author

Tests pass now.

@sanxiyn
Copy link
Member

sanxiyn commented Jun 27, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 27, 2016

📌 Commit 0abee31 has been approved by sanxiyn

@bors
Copy link
Collaborator

bors commented Jun 27, 2016

⌛ Testing commit 0abee31 with merge f019e38...

bors added a commit that referenced this pull request Jun 27, 2016
@bors bors merged commit 0abee31 into rust-lang:master Jun 27, 2016
@frewsxcv frewsxcv deleted the regress branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants