Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing code fence to diagnostics.rs #33675

Merged
merged 1 commit into from
May 18, 2016
Merged

Add missing code fence to diagnostics.rs #33675

merged 1 commit into from
May 18, 2016

Conversation

apasel422
Copy link
Contributor

Closes #33662

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 17, 2016

📌 Commit f3c63d2 has been approved by pnkfelix

@pnkfelix
Copy link
Member

pnkfelix commented May 17, 2016 •
edited
Loading

(OMG now I want to rewrite all the code examples to be song of fire and internal-compiler-error themed! Eg "a girl has no name" for an R-value temporary, plenty of jokes about destructors and lifetimes, and I'm sure we can make some Sized jokes with Tyrion. ..)

eddyb added a commit to eddyb/rust that referenced this pull request May 17, 2016
@eddyb
Rollup merge of rust-lang#33675 - apasel422:issue-33662, r=pnkfelix
a8c9eb6 
Add missing code fence to `diagnostics.rs`

Closes rust-lang#33662
@eddyb eddyb mentioned this pull request May 17, 2016
Closed
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented May 17, 2016 •
edited
Loading

@pnkfelix: You shouldn't ask for more anarchy. It'd make me add more.

And sorry for forgetting this missing code fence. 😭

Weird that it got merged without failing.

@Manishearth Manishearth mentioned this pull request May 18, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 18, 2016
@Manishearth
Rollup merge of rust-lang#33675 - apasel422:issue-33662, r=pnkfelix
9246cc4 
Add missing code fence to `diagnostics.rs`

Closes rust-lang#33662
bors added a commit that referenced this pull request May 18, 2016
@bors
Auto merge of #33710 - Manishearth:rollup, r=Manishearth
9743c66 
Rollup of 5 pull requests

- Successful merges: #33656, #33666, #33673, #33675, #33695
- Failed merges:
@bors bors merged commit f3c63d2 into rust-lang:master May 18, 2016
@apasel422 apasel422 deleted the issue-33662 branch May 18, 2016 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apasel422 @rust-highfive @pnkfelix @bors @GuillaumeGomez