Skip to content

Fix panic_fmt in the Book #32591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2016
Merged

Fix panic_fmt in the Book #32591

merged 1 commit into from
Mar 30, 2016

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Mar 29, 2016

While implementing panic_fmt for the GameCube I noticed that the parameters given to it were completely broken. Turns out that panic_fmt requires the C ABI to work correctly. This should be fixed in the documentation, so that others don't make the same mistake. Thanks to mbrubeck in the IRC for helping me figure this out.

Not specifying extern for lang_items correctly should potentially also be a compiler error.

@CryZe
Fix panic_fmt in the Book
e9b1c3c 
While implementing panic_fmt for the GameCube I noticed that the parameters given to it were completely broken. Turns out that panic_fmt requires the C ABI to work correctly. This should be fixed in the documentation, so that others don't make the same mistake. Thanks to mbrubeck in the IRC for helping me figure this out.

Not specifying extern for lang_items correctly should potentially also be a compiler error.
@steveklabnik
Copy link
Member

@bors: r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Mar 29, 2016

📌 Commit e9b1c3c has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Mar 30, 2016

⌛ Testing commit e9b1c3c with merge 17ef356...

@bors
Copy link
Collaborator

bors commented Mar 30, 2016

💔 Test failed - auto-win-gnu-64-nopt-t

@CryZe
Copy link
Contributor Author

CryZe commented Mar 30, 2016

Looks like it timed out.

Am Mittwoch, 30. März 2016 schrieb bors :

[image: 💔] Test failed - auto-win-gnu-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-nopt-t/builds/3618

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#32591 (comment)

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Mar 30, 2016 at 6:49 AM, Christopher Serr notifications@github.com
wrote:

Looks like it timed out.

Am Mittwoch, 30. März 2016 schrieb bors :

[image: 💔] Test failed - auto-win-gnu-64-nopt-t
<
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-nopt-t/builds/3618>

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#32591 (comment)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#32591 (comment)

@steveklabnik steveklabnik mentioned this pull request Mar 30, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Mar 30, 2016
@steveklabnik
Rollup merge of rust-lang#32591 - CryZe:patch-1, r=steveklabnik
6f885c3 
Fix panic_fmt in the Book

While implementing panic_fmt for the GameCube I noticed that the parameters given to it were completely broken. Turns out that panic_fmt requires the C ABI to work correctly. This should be fixed in the documentation, so that others don't make the same mistake. Thanks to mbrubeck in the IRC for helping me figure this out.

Not specifying extern for lang_items correctly should potentially also be a compiler error.
bors added a commit that referenced this pull request Mar 30, 2016
@bors
Auto merge of #32621 - steveklabnik:rollup, r=steveklabnik
bfacabc 
Rollup of 7 pull requests

- Successful merges: #32580, #32591, #32603, #32605, #32606, #32607, #32608
- Failed merges:
@bors bors merged commit e9b1c3c into rust-lang:master Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CryZe @steveklabnik @bors @alexcrichton