Skip to content

Removed usage of drop from std::net::UdpSocket docs #30511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2015

Conversation

defyrlt
Copy link

@defyrlt defyrlt commented Dec 21, 2015

Resolves #30507

r? @steveklabnik

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@tomjakubowski
Copy link
Contributor

Might be worth noting that the socket will be dropped and closed automatically when it goes out of scope.

@defyrlt
Copy link
Author

defyrlt commented Dec 22, 2015

Good point. I'll add it.
UPD: added. Now it looks somewhat like example for TcpStream.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thanks so much!

@bors
Copy link
Collaborator

bors commented Dec 30, 2015

📌 Commit 45ecdc8 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 30, 2015
bors added a commit that referenced this pull request Dec 30, 2015
@bors bors merged commit 45ecdc8 into rust-lang:master Dec 30, 2015
@defyrlt
Copy link
Author

defyrlt commented Jan 4, 2016

Glad to help :)

@defyrlt defyrlt deleted the issue_30507 branch January 4, 2016 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants