-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_privacy: Fix bugs in SanePrivacyVisitor #29726
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| // Copyright 2015 The Rust Project Developers. See the COPYRIGHT | ||
| // file at the top-level directory of this distribution and at | ||
| // http://rust-lang.org/COPYRIGHT. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
| // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| #![feature(associated_consts)] | ||
| #![feature(optin_builtin_traits)] | ||
|
|
||
| trait MarkerTr {} | ||
| pub trait Tr { | ||
| fn f(); | ||
| const C: u8; | ||
| type T; | ||
| } | ||
| pub struct S { | ||
| pub a: u8 | ||
| } | ||
| struct Ts(pub u8); | ||
|
|
||
| pub impl MarkerTr for .. {} //~ ERROR unnecessary visibility qualifier | ||
| pub impl Tr for S { //~ ERROR unnecessary visibility qualifier | ||
| pub fn f() {} //~ ERROR unnecessary visibility qualifier | ||
| pub const C: u8 = 0; //~ ERROR unnecessary visibility qualifier | ||
| pub type T = u8; //~ ERROR unnecessary visibility qualifier | ||
| } | ||
| pub impl S { //~ ERROR unnecessary visibility qualifier | ||
| pub fn f() {} | ||
| pub const C: u8 = 0; | ||
| // pub type T = u8; | ||
| } | ||
| pub extern "C" { //~ ERROR unnecessary visibility qualifier | ||
| pub fn f(); | ||
| pub static St: u8; | ||
| } | ||
|
|
||
| const MAIN: u8 = { | ||
| trait MarkerTr {} | ||
| pub trait Tr { //~ ERROR visibility has no effect inside functions or block | ||
| fn f(); | ||
| const C: u8; | ||
| type T; | ||
| } | ||
| pub struct S { //~ ERROR visibility has no effect inside functions or block | ||
| pub a: u8 //~ ERROR visibility has no effect inside functions or block | ||
| } | ||
| struct Ts(pub u8); //~ ERROR visibility has no effect inside functions or block | ||
|
|
||
| pub impl MarkerTr for .. {} //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub impl Tr for S { //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub fn f() {} //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub const C: u8 = 0; //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub type T = u8; //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| } | ||
| pub impl S { //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub fn f() {} //~ ERROR visibility has no effect inside functions or block | ||
| pub const C: u8 = 0; //~ ERROR visibility has no effect inside functions or block | ||
| // pub type T = u8; // ERROR visibility has no effect inside functions or block | ||
| } | ||
| pub extern "C" { //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub fn f(); //~ ERROR visibility has no effect inside functions or block | ||
| pub static St: u8; //~ ERROR visibility has no effect inside functions or block | ||
| } | ||
|
|
||
| 0 | ||
| }; | ||
|
|
||
| fn main() { | ||
| trait MarkerTr {} | ||
| pub trait Tr { //~ ERROR visibility has no effect inside functions or block | ||
| fn f(); | ||
| const C: u8; | ||
| type T; | ||
| } | ||
| pub struct S { //~ ERROR visibility has no effect inside functions or block | ||
| pub a: u8 //~ ERROR visibility has no effect inside functions or block | ||
| } | ||
| struct Ts(pub u8); //~ ERROR visibility has no effect inside functions or block | ||
|
|
||
| pub impl MarkerTr for .. {} //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub impl Tr for S { //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub fn f() {} //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub const C: u8 = 0; //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub type T = u8; //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| } | ||
| pub impl S { //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub fn f() {} //~ ERROR visibility has no effect inside functions or block | ||
| pub const C: u8 = 0; //~ ERROR visibility has no effect inside functions or block | ||
| // pub type T = u8; // ERROR visibility has no effect inside functions or block | ||
| } | ||
| pub extern "C" { //~ ERROR unnecessary visibility qualifier | ||
| //~^ ERROR visibility has no effect inside functions or block | ||
| pub fn f(); //~ ERROR visibility has no effect inside functions or block | ||
| pub static St: u8; //~ ERROR visibility has no effect inside functions or block | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like to always have exhaustive matches wherever possible, e.g. it's easy to skim over this list and say "ah yeah
pubis allowed on each of these". Perhaps this part could stay?