Skip to content

Conversation

@chriskrycho
Copy link
Contributor

Per @steveklabnik's comment here, the Pandoc components of the Makefile are no longer used, and as such the corresponding components of the documentation are out of date.

  • I've removed the Pandoc (and therefore also LaTeX) elements of the makefile and confirmed that the build proceeds correctly.
  • I updated the documentation to reference rustdoc and of Pandoc.

r? @steveklabnik

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 13, 2015

📌 Commit 75f7a68 has been approved by steveklabnik

@steveklabnik
Copy link
Contributor

I hope one day we can distribute these again, but when we do, this code will change anyway. /cc @killercup

@bors
Copy link
Collaborator

bors commented Aug 13, 2015

⌛ Testing commit 75f7a68 with merge b2aef9d...

bors added a commit that referenced this pull request Aug 13, 2015
…labnik

Per @steveklabnik's comment [here](rust-lang/cargo#739 (comment)), the Pandoc components of the Makefile are no longer used, and as such the corresponding components of the documentation are out of date.

  - I've removed the Pandoc (and therefore also LaTeX) elements of the makefile and confirmed that the build proceeds correctly.
  - I updated the documentation to reference `rustdoc` and  of Pandoc.

r? @steveklabnik
@bors bors merged commit 75f7a68 into rust-lang:master Aug 13, 2015
@chriskrycho chriskrycho deleted the remove_pandoc_references branch August 13, 2015 13:20
bors added a commit that referenced this pull request Oct 2, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants