Rolling up PRs in the queue #27688
Merged
Rolling up PRs in the queue #27688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code to get the LLVM type signature for the drop function doesn't handle unsized types correctly.
Instead of the actual return type, we're currently passing the function type to get_extern_fn(). The only reason this doesn't explode is because get_extern_fn() actually doesn't care about the actual return type, just about it being converging or not.
Also fixes a few outdated links.
See line 181: The lookup should start with the random index and iterate from there. Also locked stdout (which makes it a bit faster on my machine). Perhaps the multi-thread output from the fasta benchmark could be used to speed it up even more.
LLVM might perform tail merging on the calls that initiate the unwinding process which breaks debuginfo and therefore this test. Since tail merging is guaranteed to break debuginfo, it should be disabled for this test. This allows us to restore a testcase that I had to remove earlier because of the same problem, because back then I didn't realize that disabling tail merging was an option. cc rust-lang#27619
They are currently rendered incorrectly https://doc.rust-lang.org/error-index.html#E0067 https://doc.rust-lang.org/error-index.html#E0070
(that didn't seem to affect anything as the Rust type of the args wasn't getting used for code generation)
This matches the behavior of clang.
* Lots of core prelude imports removed * Makefile support for MSVC env vars and Rust crates removed * Makefile support for morestack removed
This commit leverages the runtime support for DWARF exception info added in rust-lang#27210 to enable unwinding by default on 64-bit MSVC. This also additionally adds a few minor fixes here and there in the test harness and such to get `make check` entirely passing on 64-bit MSVC: * The invocation of `maketest.py` now works with spaces/quotes in CC * debuginfo tests are disabled on MSVC * A link error for librustc was hacked around (see rust-lang#27438)
I'm not 100% sure lines 63 and 73 are typos.
As title :-) Part of rust-lang#24407. r? @Manishearth
Also fixes a few outdated links.
This matches the behavior of clang. See also discussion on rust-lang#27307.
This commit leverages the runtime support for DWARF exception info added in rust-lang#27210 to enable unwinding by default on 64-bit MSVC. This also additionally adds a few minor fixes here and there in the test harness and such to get `make check` entirely passing on 64-bit MSVC: * The invocation of `maketest.py` now works with spaces/quotes in CC * debuginfo tests are disabled on MSVC * A link error for librustc was hacked around (see rust-lang#27438)
* Lots of core prelude imports removed * Makefile support for MSVC env vars and Rust crates removed * Makefile support for morestack removed
I'm not 100% sure lines 63 and 73 are typos.
PR for [Issue rust-lang#27681] (rust-lang#27681). A simple update to the latest version of rust when typing the command rustc --version.
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: force |
|
⌛ Testing commit 6b09eb8 with merge 91364c7... |
|
💔 Test failed - auto-win-gnu-64-opt |
|
@bors: retry force |
|
⚡ Previous build results for auto-linux-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-x-android-t, auto-mac-64-nopt-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt... |
|
💔 Test failed - auto-linux-32-opt |
|
Er, segfault. Is that intermittent? |
|
@bors: retry I believe so |
bors
added a commit
that referenced
this pull request
Aug 12, 2015
This was referenced Aug 12, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.