rustdoc: Update document title when displaying search results #26401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -571,6 +571,9 @@ | |||
| return; | |||
| } | |||
|
|
|||
| // Update document title to maintain a meaningful browser history | |||
| $(document).prop("title", "Results for " + query.query + " - Rust"); | |||
There was a problem hiding this comment.
You've got a tab here and the code below and above is using only spaces...
|
Promoted tabs to spaces. |
|
@bors: r+ rollup |
|
📌 Commit d234b0b has been approved by |
|
@jooert Does this change the title back when the user exits the search mode (by pressing ESC)? (Should it?) |
|
Currently, it doesn't. But we also do not add a new entry to the browser history on pressing ESC at the moment. But, although the search query is still visible in the input field after pressing ESC, I wasn't able to go back to the results for this query (other than modifying the search query), so this whole ESC-pressing feature probably needs more work anyway. (?) |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26360.
r? @steveklabnik