Add error explanation for E0317, E0154, E0259, E0260. #25267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
meqif
changed the title
src/librustc_resolve/diagnostics.rs
Outdated
Contributor
There was a problem hiding this comment.
I love this error message, but I think the "Wrong example" wording is a bit awkward (despite its incidence elsewhere). In this case you could maybe say "Here's an example that demonstrates the error:".
Contributor
|
Looks good! |
Contributor
Author
|
Thanks for the feedback, Michael. 😄 I fixed those issues with the latest commits. |
Member
Contributor
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 12, 2015
Add diagnostic message for E0317, E0154, E0259 and E0260; part of rust-lang#24407. About E0317, I was unsure if I should add an example of what could be wrong, such as `struct i64`, `enum char { A, B }` or `type isize = i64`. I decided against it, since the diagnostic message looks clear enough to me. What do you think?
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 12, 2015
Add diagnostic message for E0317, E0154, E0259 and E0260; part of rust-lang#24407. About E0317, I was unsure if I should add an example of what could be wrong, such as `struct i64`, `enum char { A, B }` or `type isize = i64`. I decided against it, since the diagnostic message looks clear enough to me. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add diagnostic message for E0317, E0154, E0259 and E0260; part of #24407.
About E0317, I was unsure if I should add an example of what could be wrong, such as
struct i64,enum char { A, B }ortype isize = i64. I decided against it, since the diagnostic message looks clear enough to me.What do you think?