Skip to content

Add long diagnostics for E0062, E0063 and E0137 #25200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2015
Merged

Add long diagnostics for E0062, E0063 and E0137 #25200

merged 3 commits into from
May 10, 2015

Conversation

@nham
Copy link
Contributor

@nham nham commented May 8, 2015

cc #24407

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton
alexcrichton reviewed May 8, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could elaborate in saying that each field must be specified exactly one time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a good suggestion. I've added this.

@alexcrichton
Copy link
Member

@bors: r+ c8cf370 rollup

@alexcrichton alexcrichton assigned alexcrichton and unassigned pcwalton May 8, 2015
@Manishearth Manishearth mentioned this pull request May 8, 2015
Merged
bors added a commit that referenced this pull request May 8, 2015
@bors
Auto merge of #25218 - Manishearth:rollup, r=Manishearth
b210aea 
- Successful merges: #24864, #25140, #25179, #25181, #25190, #25194, #25195, #25198, #25203, #25210, #25211, #25215
- Failed merges: #25200
@bors
Copy link
Collaborator

bors commented May 8, 2015

☔ The latest upstream changes (presumably #25218) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented May 9, 2015

🔒 Merge conflict

@nham
Copy link
Contributor Author

nham commented May 9, 2015

rebased

@alexcrichton
Copy link
Member

@bors: r+ df64e05 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request May 10, 2015
@Manishearth
Rollup merge of rust-lang#25200 - nham:E0062_E0063, r=alexcrichton
c145cda 
cc rust-lang#24407
Manishearth added a commit to Manishearth/rust that referenced this pull request May 10, 2015
@Manishearth
Rollup merge of rust-lang#25200 - nham:E0062_E0063, r=alexcrichton
15c9f44 
cc rust-lang#24407
@Manishearth Manishearth mentioned this pull request May 10, 2015
Merged
bors added a commit that referenced this pull request May 10, 2015
@bors
Auto merge of #25262 - Manishearth:rollup, r=Manishearth
750f2c6 
- Successful merges: #25200, #25242, #25248, #25249, #25251, #25252, #25261
- Failed merges: #25255
@bors bors merged commit df64e05 into rust-lang:master May 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nham @rust-highfive @alexcrichton @bors @pcwalton