Skip to content

TRPL: casting #24632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2015
Merged

TRPL: casting #24632

merged 1 commit into from
Apr 21, 2015

Conversation

steveklabnik
Copy link
Member

Due to documenting transmute, addresses part of #12905

Due to documenting `transmute`, addresses part of rust-lang#12905
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 9a65045 rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 20, 2015
…richton

Due to documenting `transmute`, addresses part of rust-lang#12905
bors added a commit that referenced this pull request Apr 20, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 21, 2015
…richton

Due to documenting `transmute`, addresses part of rust-lang#12905
bors added a commit that referenced this pull request Apr 21, 2015

It’s a ‘non-scalar cast’ because we have multiple values here: the four
elements of the array. These kinds of casts are very dangerous, because they
make assumptions about the way that multiple underlying strucutres are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/strucutres/structures/

@bors bors merged commit 9a65045 into rust-lang:master Apr 21, 2015
@mdinger mdinger mentioned this pull request Apr 21, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 21, 2015
This just fixes some comments made on rust-lang#24632 . The second I think is better unless @steveklabnik actually meant something else.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants