rustdoc: don't inject "extern crate std;" #24597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #24332 as well |
|
Yes. |
|
@bors: r+ |
|
📌 Commit adc93ce has been approved by |
|
⌛ Testing commit adc93ce with merge e959fab... |
bors
added a commit
that referenced
this pull request
Apr 20, 2015
This patch will make links like http://doc.rust-lang.org/std/collections/struct.BTreeMap.html#examples actually playable without modifying the code. It seems that this patch cannot be tested on test/rustdoc. And I suggest adding a `&run=1` to those links. Thank @jorisgio for noticing me this! r? @steveklabnik Closes #24332
|
When I click on the playpen link in the example, I land up here: https://play.rust-lang.org/?code=extern%20crate%20std%3B%0Afn%20main()%20%7B%0A%20%20%20%20use%20std%3A%3Acollections%3A%3ABTreeMap%3B%0A%20%20%20%20%0A%20%20%20%20let%20mut%20a%20%3D%20BTreeMap%3A%3Anew()%3B%0A%20%20%20%20a.insert(1%2C%20%22a%22)%3B%0A%20%20%20%20a.clear()%3B%0A%20%20%20%20assert!(a.is_empty())%3B%0A%20%20%20%20%0A%7D And this fails with this error: |
|
@achanda this was just merged four hours ago, you won't be able to see the changes till tomorrow :) |
|
oh :) thanks @steveklabnik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will make links like http://doc.rust-lang.org/std/collections/struct.BTreeMap.html#examples actually playable without modifying the code.
It seems that this patch cannot be tested on test/rustdoc.
And I suggest adding a
&run=1to those links.Thank @jorisgio for noticing me this!
r? @steveklabnik
Closes #24332