Skip to content

For FRU, eval field exprs (into scratch temps) before base expr #23201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2015

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Mar 8, 2015

For FRU, eval field exprs (into scratch temps) before base expr

Fix #23112.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 8, 2015

(I am running make check now; e.g. it is possible I have e.g. messed up debuginfo stuff. I will post after that finishes.)

@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 9, 2015

make check completed successfully

@pnkfelix pnkfelix force-pushed the fsk-struct-ooe-23112 branch from abdb561 to 3dbf969 Compare March 9, 2015 13:50
@nikomatsakis
Copy link
Contributor

@bors r+ 3dbf969

@bors
Copy link
Collaborator

bors commented Mar 10, 2015

⌛ Testing commit 3dbf969 with merge b8dbd47...

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 10, 2015
…komatsakis

 For FRU, eval field exprs (into scratch temps) before base expr

Fix rust-lang#23112.
@bors
Copy link
Collaborator

bors commented Mar 10, 2015

💔 Test failed - auto-win-32-nopt-t

@Manishearth
Copy link
Member

@bors: retry

@bors bors merged commit 3dbf969 into rust-lang:master Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

struct order of eval is (still) not well
5 participants