unbreak openbsd after nacl intergration #22792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
@semarie I'm in the process of catching up to HEAD building snapshots. I'll know in a day if this is a problem. A cursory glance suggests that it is a problem. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 25, 2015
…xcrichton
The recent commit on liblibc for nacl break the compilation for OpenBSD (and Bitrig too, I think).
The problem is `ino_t` come from another block too now. This patch remove the extra declaration.
```
.../src/liblibc/lib.rs:98:9: 98:37 error: a type named `ino_t` has already been imported in this module [E0251]
.../src/liblibc/lib.rs:98 pub use types::os::arch::posix01::*;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
```
@dhuseby do you have this problem too ? and if yes, does this patch correct it ?
|
@semarie yup, I just ran into the break building the latest HEAD using the my most recent bitrig snapshot. I have a couple other fixes to submit as well. |
semarie
added a commit
to semarie/rust
that referenced
this pull request
Mar 1, 2015
this is the same problem as openbsd (rust-lang#22792). without the patch, liblibc don't build.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 1, 2015
…hton this is the same problem as openbsd (rust-lang#22792). without the patch, liblibc don't build. @mneumann please comment. I have encountered this problem while building some rust libs with `target=x86_64-unknown-dragonfly` (while working on rust-lang#22794)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent commit on liblibc for nacl break the compilation for OpenBSD (and Bitrig too, I think).
The problem is
ino_tcome from another block too now. This patch remove the extra declaration.@dhuseby do you have this problem too ? and if yes, does this patch correct it ?