std: Update the std::io adaptors to proxy all methods #22428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| if try!(self.write(data)) == data.len() { | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::new(ErrorKind::WriteZero, "failed to write whole buffer", None)) |
There was a problem hiding this comment.
WriteZero seems like the wrong error for this.
There was a problem hiding this comment.
@sfackler: yeah, I agree. I kept the WriteZero because that's the error the Read::write_all supermethod returns. The fact that I'm not doing the loop is more of an implementation detail. Is it worth making a PartialWrite error kind?
There was a problem hiding this comment.
This is indeed what WriteZero is intended for, but I think PartialWrite is actually a better name for it! cc @alexcrichton
|
⌛ Testing commit ded93b1 with merge 2e7441f... |
|
💔 Test failed - auto-win-64-nopt-t |
|
@bors: retry |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
Also includes some minor optimizations to the Vec and slice writers to remove the unnecessary loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some minor optimizations to the Vec and slice writers to remove the unnecessary loop.