Deprecate std::sync::TaskPool #22427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than stabilize on the current API, we're going to punt this concern to crates.io, to allow for faster iteration. If you need this functionality, you might look at https://github.com/carllerche/syncbox [breaking-change]
aturon
force-pushed
the
deprecate-taskpool
branch
from
ed0cb96 to
efd2a17
Compare
|
@reem done |
|
It seems like someone could copy this code out into a standalone crate onto crates.io, to give users a drop-in replacement for now? |
|
@huonw The new thread semantics make it really tricky to actually use, so I don't think that would be very helpful. |
|
I too agree with @huonw that if we are deprecating in favor of another implementation it should probably be a drop in replacement (and up-to-date on crates.io) |
|
Ok, no real harm (though we'll eventually want to garbage collect these, somehow...) I'll get it set up, and we can wait to land this until I have a link to point to :-) |
|
Continuing in #22783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than stabilize on the current API, we're going to punt this
concern to crates.io, to allow for faster iteration.
[breaking-change]
r? @alexcrichton