Skip to content

Conversation

@thiagooak
Copy link

@steveklabnik Trying out the Glossary idea.

Added the paragraph about 'complicated words' because I think it would be useful to those contributing to the book. Maybe this should not be here

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to be a bit more positive here. I'm not sure exactly what I'd want to write, but something more like "not everyone who comes to Rust has a background in systems programming, nor in computer science, so we've added explanations of domain terms that might be unfamilliar" or something

@thiagooak
Copy link
Author

Really like the way you wrote it, did small changes

"Not every Rustacean has a background in systems programming, nor in computer
science, so we've added explanations of terms that might be unfamiliar."

  • not sure if Rustacean is really a thing, but if it is I like the idea to add it
  • maybe could be "not every new Rustacean" but sounds a bit demeaning
  • removed domain from "domain terms" - simpler and has similar effect

@steveklabnik
Copy link
Contributor

I already mention Rustaceans, so it's fine to add here :)

@steveklabnik
Copy link
Contributor

@bors: r+ 9783cc2 rollup

@steveklabnik
Copy link
Contributor

Awesome, thanks!

@kmcallister
Copy link
Contributor

Nice! Is there a wiki page etc. where we can add terms to be glossarized?

Also, it'd be great to enhance rustdoc such that we can cross-link possibly unfamiliar terms between the glossary and the text.

@steveklabnik
Copy link
Contributor

Is there a wiki page etc. where we can add terms to be glossarized?

Just submit pull requests, though I don't want this to get out of hand. Primarily focusing on CS terms here.

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 17, 2015
…bnik

@steveklabnik Trying out the Glossary idea.

Added the paragraph about 'complicated words' because I think it would be useful to those contributing to the book. Maybe this should not be here
@bors bors merged commit 9783cc2 into rust-lang:master Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants