Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docs fallback font 'serif', rather than 'sans-serif' #22097

Merged
merged 1 commit into from
Feb 10, 2015

Conversation

cllns
Copy link
Contributor

@cllns cllns commented Feb 8, 2015

The fallback font for a serif font should also be serif, not sans serif.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@nagisa
Copy link
Member

nagisa commented Feb 8, 2015

Why remove Helvetica, Arial and friends?

@cllns
Copy link
Contributor Author

cllns commented Feb 8, 2015

@nagisa because they're sans-serif fonts. If "Source Serif Pro" cannot load, we should load another serif font, not a sans-serif one.

@steveklabnik
Copy link
Member

I agree with this conceptually, but the gap between "Source Serif Pro" and serif is pretty huge. Maybe put another one or two in there too? http://www.smashingmagazine.com/2009/09/22/complete-guide-to-css-font-stacks/

@iKevinY
Copy link
Contributor

iKevinY commented Feb 8, 2015

If we were to remove the sans-serif fallbacks in favour of serif fonts, I think a Georgia-based stack would work pretty well. It supposedly has good compatibility and looks somewhat similar to Source Serif Pro.

font-family: "Source Serif Pro", Georgia, Times, Times New Roman, serif;

@cllns
Copy link
Contributor Author

cllns commented Feb 9, 2015

Good call! Just updated it to the Georgia stack as the fallback.

@alexcrichton
Copy link
Member

r? @steveklabnik

@steveklabnik
Copy link
Member

@bors: r+ 45f6672 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 10, 2015
…abnik

The fallback font for a serif font should also be serif, not sans serif.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 10, 2015
The fallback font for a serif font should also be serif, not sans serif.
@bors bors merged commit 45f6672 into rust-lang:master Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants